From d03b88cf83939ad6ae0cb9a110ef1d688becace6 Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 7 Jul 2023 17:34:10 +1000 Subject: [PATCH] Rename variables To make it clear they are arrays --- app/webpacker/controllers/dropdown_controller.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/webpacker/controllers/dropdown_controller.js b/app/webpacker/controllers/dropdown_controller.js index 35d13511bb..19a3dc8b7a 100644 --- a/app/webpacker/controllers/dropdown_controller.js +++ b/app/webpacker/controllers/dropdown_controller.js @@ -4,8 +4,8 @@ export default class extends Controller { static targets = ["arrow", "menu"]; connect() { - this.collapsedClass = this.arrowTarget.dataset.collapsedClass.split(" "); - this.expandedClass = this.arrowTarget.dataset.expandedClass.split(" "); + this.collapsedClasses = this.arrowTarget.dataset.collapsedClass.split(" "); + this.expandedClasses = this.arrowTarget.dataset.expandedClass.split(" "); this.#hide(); document.addEventListener("click", this.#onBodyClick.bind(this)); } @@ -33,12 +33,12 @@ export default class extends Controller { #show() { this.menuTarget.classList.remove("hidden"); - this.arrowTarget.classList.remove(...this.collapsedClass); - this.arrowTarget.classList.add(...this.expandedClass); + this.arrowTarget.classList.remove(...this.collapsedClasses); + this.arrowTarget.classList.add(...this.expandedClasses); } #hide() { this.menuTarget.classList.add("hidden"); - this.arrowTarget.classList.remove(...this.expandedClass); - this.arrowTarget.classList.add(...this.collapsedClass); + this.arrowTarget.classList.remove(...this.expandedClasses); + this.arrowTarget.classList.add(...this.collapsedClasses); } }