From 1e79fde2363b0fd5a739bf56a4fa303029efbe96 Mon Sep 17 00:00:00 2001 From: filipefurtad0 Date: Fri, 16 Aug 2024 14:32:35 -0600 Subject: [PATCH 1/2] Reproduces S2 bug #12768 --- spec/system/admin/reports_spec.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/spec/system/admin/reports_spec.rb b/spec/system/admin/reports_spec.rb index 62de258992..18ff2ffd99 100644 --- a/spec/system/admin/reports_spec.rb +++ b/spec/system/admin/reports_spec.rb @@ -499,12 +499,16 @@ RSpec.describe ' end describe 'bulk coop report' do + let!(:order) { create(:completed_order_with_totals) } + before do login_as_admin visit admin_reports_path end it "generating Bulk Co-op Supplier Report" do + pending("S2 bug #12768") + click_link "Bulk Co-op Supplier Report" run_report From a78f46259c2de918a1c43d5b45373eeb98708569 Mon Sep 17 00:00:00 2001 From: filipefurtad0 Date: Mon, 19 Aug 2024 11:42:02 -0600 Subject: [PATCH 2/2] Asserts on the flash warning first The warning first displays "Saving..." before confirming changes are saved. I'm not entirelly sure, but it seems that asserting on this first, before asserting on other page elements stabilizes the spec. --- spec/system/admin/order_cycles/edit_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/system/admin/order_cycles/edit_spec.rb b/spec/system/admin/order_cycles/edit_spec.rb index 1e85a071f5..c3899aa35e 100644 --- a/spec/system/admin/order_cycles/edit_spec.rb +++ b/spec/system/admin/order_cycles/edit_spec.rb @@ -144,8 +144,8 @@ RSpec.describe ' # click save click_button('Save') - expect(page.find('#order_cycle_name').value).to eq 'OC1 name updated' expect(page).to have_content('Your order cycle has been updated.') + expect(page.find('#order_cycle_name').value).to eq 'OC1 name updated' # Now change date range field value find('#order_cycle_orders_close_at').click @@ -157,9 +157,9 @@ RSpec.describe ' expect(page).to have_content('You have unsaved changes') click_button('Save') + expect(page).to have_content('Your order cycle has been updated.') expect(page).not_to have_content "Orders are linked to this cycle" expect(page).to have_field 'order_cycle_orders_close_at', with: '2024-03-30 00:00' - expect(page).to have_content('Your order cycle has been updated.') end end end