From cf31d09ad8ac60626db7aecbda78e93841bbc6ea Mon Sep 17 00:00:00 2001 From: David Cook Date: Tue, 26 Mar 2024 11:10:29 +1100 Subject: [PATCH] Prevent submitting empty value --- app/views/admin/products_v3/_variant_row.html.haml | 2 +- spec/system/admin/products_v3/products_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views/admin/products_v3/_variant_row.html.haml b/app/views/admin/products_v3/_variant_row.html.haml index 53f56435de..73a1385f32 100644 --- a/app/views/admin/products_v3/_variant_row.html.haml +++ b/app/views/admin/products_v3/_variant_row.html.haml @@ -20,7 +20,7 @@ -# todo: create a method for value_with_description = f.text_field :unit_value_with_description, value: [number_with_precision(variant.unit_value, precision: nil,strip_insignificant_zeros: true), variant.unit_description].compact_blank.join(" "), - 'aria-label': t('admin.products_page.columns.unit_value') + 'aria-label': t('admin.products_page.columns.unit_value'), required: true .field = f.label :display_as, t('admin.products_page.columns.display_as') = f.text_field :display_as, placeholder: VariantUnits::OptionValueNamer.new(variant).name diff --git a/spec/system/admin/products_v3/products_spec.rb b/spec/system/admin/products_v3/products_spec.rb index aafc4ee125..a7554c1121 100644 --- a/spec/system/admin/products_v3/products_spec.rb +++ b/spec/system/admin/products_v3/products_spec.rb @@ -192,9 +192,9 @@ describe 'As an admin, I can manage products', feature: :admin_style_v3 do # Unit popout # TODO: prevent empty value - # fill_in "Unit value", with: "" - # click_button "Save changes" # attempt to save or close the popout - # expect(page).to have_field "Unit value", with: "" # popout is still open + fill_in "Unit value", with: "" + click_button "Save changes" # attempt to save or close the popout + expect(page).to have_field "Unit value", with: "" # popout is still open fill_in "Unit value", with: "500.1" within row_containing_name("Medium box") do