From ce5bcaaa207be4dc56283574462c0fd7dac62f0f Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 7 Aug 2020 14:46:08 +0100
Subject: [PATCH] Explicitly notify Bugsnag on checkout failure

---
 .../javascripts/darkswarm/services/checkout.js.coffee  |  3 ++-
 .../unit/darkswarm/services/checkout_spec.js.coffee    | 10 ++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/app/assets/javascripts/darkswarm/services/checkout.js.coffee b/app/assets/javascripts/darkswarm/services/checkout.js.coffee
index 4ec3081ad3..d74f075ea3 100644
--- a/app/assets/javascripts/darkswarm/services/checkout.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/checkout.js.coffee
@@ -24,7 +24,8 @@ Darkswarm.factory 'Checkout', ($injector, CurrentOrder, ShippingMethods, StripeE
           try
             @loadFlash(error: t("checkout.failed")) # inform the user about the unexpected error
           finally
-            throw error # generate a BugsnagJS alert
+            Bugsnag.notify(error)
+            throw error
 
     handle_checkout_error_response: (response) =>
       throw response unless response.data?
diff --git a/spec/javascripts/unit/darkswarm/services/checkout_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/checkout_spec.js.coffee
index d7e23b457b..8caacdc531 100644
--- a/spec/javascripts/unit/darkswarm/services/checkout_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/services/checkout_spec.js.coffee
@@ -1,4 +1,6 @@
 describe 'Checkout service', ->
+  BugsnagMock =
+    notify: (arg) ->
   Checkout = null
   orderData = null
   $httpBackend = null
@@ -48,6 +50,8 @@ describe 'Checkout service', ->
       ship_address: {test: "bar"}
       user_id: 901
 
+    window.Bugsnag = BugsnagMock
+
     module 'Darkswarm'
     module ($provide)->
       $provide.value "RailsFlashLoader", FlashLoaderMock
@@ -128,6 +132,7 @@ describe 'Checkout service', ->
         expect(Checkout.errors).toEqual {error: "frogs"}
 
       it "throws exception and sends generic flash message when there are errors but no flash message", ->
+        spyOn(BugsnagMock, "notify")
         $httpBackend.expectPUT("/checkout.json").respond 400, {errors: {error: "broken response"}}
         try
           Checkout.submit()
@@ -136,9 +141,11 @@ describe 'Checkout service', ->
           expect(error.data.errors.error).toBe("broken response")
 
         expect(Checkout.errors).toEqual {}
+        expect(BugsnagMock.notify).toHaveBeenCalled()
 
       it "throws an exception and sends a flash message to the flash service when reponse doesnt contain errors nor a flash message", ->
         spyOn(FlashLoaderMock, "loadFlash") # Stubbing out writes to window.location
+        spyOn(BugsnagMock, "notify")
         $httpBackend.expectPUT("/checkout.json").respond 400, "broken response"
         try
           Checkout.submit()
@@ -147,9 +154,11 @@ describe 'Checkout service', ->
           expect(error.data).toBe("broken response")
 
         expect(FlashLoaderMock.loadFlash).toHaveBeenCalledWith({ error: t("checkout.failed") })
+        expect(BugsnagMock.notify).toHaveBeenCalled()
 
       it "throws an exception and sends a flash message to the flash service when an exception is thrown while handling the error", ->
         spyOn(FlashLoaderMock, "loadFlash") # Stubbing out writes to window.location
+        spyOn(BugsnagMock, "notify")
         navigationSpy.and.callFake(-> throw "unexpected error")
         $httpBackend.expectPUT("/checkout.json").respond 400, {path: 'path'}
         try
@@ -159,6 +168,7 @@ describe 'Checkout service', ->
           expect(error).toBe("unexpected error")
 
         expect(FlashLoaderMock.loadFlash).toHaveBeenCalledWith({ error: t("checkout.failed") })
+        expect(BugsnagMock.notify).toHaveBeenCalled()
 
     describe "when using the Stripe Connect gateway", ->
       beforeEach inject ($injector, StripeElements) ->