From 522a7384e743ceab6b6a2db1794be5aff2668fdc Mon Sep 17 00:00:00 2001 From: Nihal Mohammed Date: Fri, 11 Jun 2021 22:07:05 +0530 Subject: [PATCH] Fix HTML bug on new payment method page and update providers_controller spec --- .../payment_methods/controllers/providers_controller.js.coffee | 2 +- .../unit/admin/controllers/providers_controller_spec.js.coffee | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/admin/payment_methods/controllers/providers_controller.js.coffee b/app/assets/javascripts/admin/payment_methods/controllers/providers_controller.js.coffee index 6b9669c9e7..e88ec4b991 100644 --- a/app/assets/javascripts/admin/payment_methods/controllers/providers_controller.js.coffee +++ b/app/assets/javascripts/admin/payment_methods/controllers/providers_controller.js.coffee @@ -2,6 +2,6 @@ angular.module("admin.paymentMethods").controller "ProvidersCtrl", ($scope, paym if paymentMethod.type $scope.include_html = "/admin/payment_methods/show_provider_preferences?" + "provider_type=#{paymentMethod.type};" + - "pm_id=#{paymentMethod.id};" + "pm_id=#{paymentMethod.id || ''};" else $scope.include_html = "" diff --git a/spec/javascripts/unit/admin/controllers/providers_controller_spec.js.coffee b/spec/javascripts/unit/admin/controllers/providers_controller_spec.js.coffee index 4cbf017244..7d67222d90 100644 --- a/spec/javascripts/unit/admin/controllers/providers_controller_spec.js.coffee +++ b/spec/javascripts/unit/admin/controllers/providers_controller_spec.js.coffee @@ -27,4 +27,4 @@ describe "ProvidersCtrl", -> ctrl = $controller 'ProvidersCtrl', {$scope: scope, paymentMethod: paymentMethod } it "sets the include_html porperty on scope to some address", -> - expect(scope.include_html).toBe "/admin/payment_methods/show_provider_preferences?provider_type=NOT NULL;pm_id=#{paymentMethod.id};" + expect(scope.include_html).toBe "/admin/payment_methods/show_provider_preferences?provider_type=NOT NULL;pm_id=#{paymentMethod.id || ''};"