From ca4aa645f70a2921ce5e78cec6a576e8b41ea3b7 Mon Sep 17 00:00:00 2001
From: cyrillefr <cyrille.vasseur@gmail.com>
Date: Thu, 18 Jan 2024 10:10:49 +0100
Subject: [PATCH] Delete now ununsed stimulus controller toggle_button_disabled

- also delete one comment about replacing this controller with another
---
 .../toggle_button_disabled_controller.js      | 24 ------
 .../controllers/toggle_control_controller.js  |  1 -
 .../toggle_button_disabled_controller_test.js | 81 -------------------
 3 files changed, 106 deletions(-)
 delete mode 100644 app/webpacker/controllers/toggle_button_disabled_controller.js
 delete mode 100644 spec/javascripts/stimulus/toggle_button_disabled_controller_test.js

diff --git a/app/webpacker/controllers/toggle_button_disabled_controller.js b/app/webpacker/controllers/toggle_button_disabled_controller.js
deleted file mode 100644
index 7ef9233217..0000000000
--- a/app/webpacker/controllers/toggle_button_disabled_controller.js
+++ /dev/null
@@ -1,24 +0,0 @@
-import { Controller } from "stimulus";
-
-// Since Rails 7 it adds "data-disabled-with" property to submit, you'll need to add
-// 'data-disable-with="false' for this to function as expected, ie:
-//
-//    <input id="test-submit" type="submit" data-disable-with="false" data-toggle-button-disabled-target="button"/>
-//
-export default class extends Controller {
-  static targets = ["button"];
-
-  connect() {
-    if (this.hasButtonTarget) {
-      this.buttonTarget.disabled = true;
-    }
-  }
-
-  inputIsChanged(e) {
-    if (e.target.value !== "") {
-      this.buttonTarget.disabled = false;
-    } else {
-      this.buttonTarget.disabled = true;
-    }
-  }
-}
diff --git a/app/webpacker/controllers/toggle_control_controller.js b/app/webpacker/controllers/toggle_control_controller.js
index 05b777b9ed..81828d3514 100644
--- a/app/webpacker/controllers/toggle_control_controller.js
+++ b/app/webpacker/controllers/toggle_control_controller.js
@@ -25,7 +25,6 @@ export default class extends Controller {
       target.disabled = !enable;
     });
   }
-  //todo: can a new method disableIfBlank replace ButtonDisabledController?
   //todo: can a new method toggleDisplay replace ToggleController?
   //todo: can toggleDisplay with optional chevron-target replace RemoteToggleController?
 
diff --git a/spec/javascripts/stimulus/toggle_button_disabled_controller_test.js b/spec/javascripts/stimulus/toggle_button_disabled_controller_test.js
deleted file mode 100644
index 2c367fdb11..0000000000
--- a/spec/javascripts/stimulus/toggle_button_disabled_controller_test.js
+++ /dev/null
@@ -1,81 +0,0 @@
-/**
- * @jest-environment jsdom
- */
-
-import { Application } from "stimulus"
-import toggle_button_disabled_controller from "../../../app/webpacker/controllers/toggle_button_disabled_controller"
-
-describe("ButtonEnableToggleController", () => {
-  beforeAll(() => {
-    const application = Application.start()
-    application.register("toggle-button-disabled", toggle_button_disabled_controller)
-  })
-
-  beforeEach(() => {
-    document.body.innerHTML = `
-      <form id="test-form" data-controller="toggle-button-disabled">
-        <input id="test-input" type="input" data-action="input->toggle-button-disabled#inputIsChanged" />
-        <input 
-          id="test-submit" 
-          type="submit" 
-          data-disable-with="false" 
-          data-toggle-button-disabled-target="button"
-        />
-      </form>
-    `
-  })
-
-  describe("#connect", () => {
-    it("disables the target submit button", () => {
-      const submit = document.getElementById("test-submit")
-      expect(submit.disabled).toBe(true)
-    })  
-
-    describe("when no button present", () => {
-      beforeEach(() => {
-        document.body.innerHTML = `
-          <form id="test-form" data-controller="toggle-button-disabled">
-            <input id="test-input" type="input" data-action="input->toggle-button-disabled#inputIsChanged" />
-          </form>
-        `
-      })
-
-      // I am not sure if it's possible to manually trigger the loading/connect of the controller to 
-      // try catch the error, so leaving as this. It will break if the missing target isn't handled
-      // properly
-      it("doesn't break", () => {})  
-    })  
-  })
-
-  describe("#formIsChanged", () => {
-    let input 
-    let submit 
-
-    beforeEach(() => {
-      input = document.getElementById("test-input")
-      submit = document.getElementById("test-submit")
-    })
-
-    describe("when the input value is not empty", () => {
-      it("enables the target button", () => {
-        input.value = "test"
-        input.dispatchEvent(new Event("input"));
-
-        expect(submit.disabled).toBe(false)
-      })
-    }) 
-
-    describe("when the input value is empty", () => {
-      it("disables the target button", () => {
-        // setting up state where target button is enabled
-        input.value = "test"
-        input.dispatchEvent(new Event("input"));
-
-        input.value = ""
-        input.dispatchEvent(new Event("input"));
-
-        expect(submit.disabled).toBe(true)
-      })
-    }) 
-  })
-})