From ca3c0c98bf2564974012cd762aa23811fd703064 Mon Sep 17 00:00:00 2001 From: David Cook Date: Mon, 23 Mar 2026 17:22:17 +1100 Subject: [PATCH] Don't group reviewdog output Grouping is a nice feature, but it wasn't helpful here. If there's an error in rubocop for example, the rubocop section will be collapsed, and because we didn't close the group, the haml group was always open. So it wasn't clear where the error was. Better to just show all the output, which isn't very long, so you can see where the problem is straight away. Even better would be to add support for GitHub Actions annotations. I thought we used to have that turned on, not sure why it's not working now. --- script/reviewdog.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/script/reviewdog.sh b/script/reviewdog.sh index 5bde805fba..a02df06e4f 100755 --- a/script/reviewdog.sh +++ b/script/reviewdog.sh @@ -6,7 +6,7 @@ set -o pipefail -echo "::group:: Running prettier with reviewdog 🐶 ..." +echo -e "\nRunning prettier with reviewdog 🐶 ..." "$(npm root)/.bin/prettier" --check . 2>&1 | sed --regexp-extended 's/(\[warn\].*)$/\1 File is not properly formatted./' \ | reviewdog \ @@ -25,7 +25,7 @@ echo "::group:: Running prettier with reviewdog 🐶 ..." prettier=$? -echo "::group:: Running rubocop with reviewdog 🐶 ..." +echo -e "\nRunning rubocop with reviewdog 🐶 ..." bundle exec rubocop \ --fail-level info \ @@ -39,7 +39,7 @@ bundle exec rubocop \ rubocop=$? -echo "::group:: Running haml-lint with reviewdog 🐶 ..." +echo -e "\nRunning haml-lint with reviewdog 🐶 ..." bundle exec haml-lint \ --fail-level warning \