From ca268d5c84bca9d15d2c9d9f33389eb1da1b801f Mon Sep 17 00:00:00 2001 From: Pau Perez Date: Mon, 8 Mar 2021 13:34:57 +0100 Subject: [PATCH] Remove unnecessary indirection in test --- .../admin/configuration/general_settings_spec.rb | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/spec/features/admin/configuration/general_settings_spec.rb b/spec/features/admin/configuration/general_settings_spec.rb index 6c5b70a4ba..e4ad401365 100644 --- a/spec/features/admin/configuration/general_settings_spec.rb +++ b/spec/features/admin/configuration/general_settings_spec.rb @@ -5,7 +5,7 @@ require 'spec_helper' describe "General Settings" do include AuthenticationHelper - before(:each) do + before do login_as_admin_and_visit spree.admin_dashboard_path click_link "Configuration" click_link "General Settings" @@ -24,16 +24,10 @@ describe "General Settings" do fill_in "site_name", with: "OFN Demo Site99" click_button "Update" - assert_successful_update_message(:general_settings) - - expect(find("#site_name").value).to eq("OFN Demo Site99") - end - - def assert_successful_update_message(resource) - flash = Spree.t(:successfully_updated, resource: Spree.t(resource)) within("[class='flash success']") do - expect(page).to have_content(flash) + expect(page).to have_content(Spree.t(:successfully_updated, resource: Spree.t(:general_settings))) end + expect(find("#site_name").value).to eq("OFN Demo Site99") end end end