raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-01 21:47:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

BPUR: Don't use master variant to update attributes. Changes to product filtering.

Browse Source
This commit is contained in:
Rob H
2013-06-02 08:52:41 +05:30
committed by Rohan Mitchell
parent 0ca0abd0b2
commit c80cba7fa5
7 changed files with 74 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
spec/javascripts/unit/bulk_product_update_spec.js
View File

@@ -140,7 +140,7 @@ describe("Auxillary functions", function(){
expect( getDirtyObjects(c, d) ).toEqual( [ { id: 2, value: 12 }, { id: 3, value2: 15 } ] );
});
});
describe("filtering products", function(){
it("only accepts and returns an array", function(){
expect( filterSubmitProducts( [] ) ).toEqual([]);
@@ -155,9 +155,14 @@ describe("Auxillary functions", function(){
expect( filterSubmitProducts( [ { id: 1, name: "p1" }, { notanid: 2, name: "p2"} ] ) ).toEqual( [ { id: 1, name: "p1" } ]);
});
it("returns variants as variants_attributes", function(){
it("does not return a product object for products which have no propeties other than an id", function(){
expect( filterSubmitProducts( [ { id: 1, someunwantedproperty: "something" }, { id: 2, name: "p2"} ] ) ).toEqual( [ { id: 2, name: "p2" } ]);
});
it("does not return an on_hand count when a product has variants", function(){
var testProduct = {
id: 1,
on_hand: 5,
variants: [ {
id: 1,
on_hand: 5,
@@ -174,10 +179,10 @@ describe("Auxillary functions", function(){
} ] );
});
it("returns master as master_attributes", function(){
it("returns variants as variants_attributes", function(){
var testProduct = {
id: 1,
master: [ {
variants: [ {
id: 1,
on_hand: 5,
price: 12.0
@@ -185,7 +190,7 @@ describe("Auxillary functions", function(){
};
expect( filterSubmitProducts( [ testProduct ] ) ).toEqual( [ {
id: 1,
master_attributes: [ {
variants_attributes: [ {
id: 1,
on_hand: 5,
price: 12.0
@@ -222,6 +227,18 @@ describe("Auxillary functions", function(){
} ] );
});
it("does not return variants_attributes property if variants is an empty array", function(){
var testProduct = {
id: 1,
price: 10,
variants: []
};
expect( filterSubmitProducts( [ testProduct ] ) ).toEqual( [ {
id: 1,
price: 10
} ] );
});
// TODO Not an exhaustive test, is there a better way to do this?
it("only returns properties the properties of products which ought to be updated", function(){
var testProduct = {