From c5a17bcde0c41982d53256dbe6c12cf410f868f4 Mon Sep 17 00:00:00 2001 From: luisramos0 Date: Tue, 17 Sep 2019 18:56:55 +0100 Subject: [PATCH] Fix rubocop issues in feature specs related to configuration --- spec/features/admin/configuration/general_settings_spec.rb | 2 +- spec/features/admin/configuration/image_settings_spec.rb | 6 +++--- spec/features/admin/configuration/mail_methods_spec.rb | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/spec/features/admin/configuration/general_settings_spec.rb b/spec/features/admin/configuration/general_settings_spec.rb index f066c26340..0577d44cd6 100644 --- a/spec/features/admin/configuration/general_settings_spec.rb +++ b/spec/features/admin/configuration/general_settings_spec.rb @@ -20,7 +20,7 @@ describe "General Settings" do context "editing general settings (admin)" do it "should be able to update the site name" do - fill_in "site_name", :with => "Spree Demo Site99" + fill_in "site_name", with: "Spree Demo Site99" click_button "Update" assert_successful_update_message(:general_settings) diff --git a/spec/features/admin/configuration/image_settings_spec.rb b/spec/features/admin/configuration/image_settings_spec.rb index c9e1455376..ff22c6a7c6 100644 --- a/spec/features/admin/configuration/image_settings_spec.rb +++ b/spec/features/admin/configuration/image_settings_spec.rb @@ -12,9 +12,9 @@ describe "image settings" do # Regression test for #2344 it "can update attachment_url" do - fill_in "Attachments URL", :with => "foobar" - fill_in "Attachments Default URL", :with => "barfoo" - fill_in "Attachments Path", :with => "spec/dummy/tmp/bfaoro" + fill_in "Attachments URL", with: "foobar" + fill_in "Attachments Default URL", with: "barfoo" + fill_in "Attachments Path", with: "spec/dummy/tmp/bfaoro" click_button "Update" expect(Spree::Config[:attachment_url]).to eq("foobar") diff --git a/spec/features/admin/configuration/mail_methods_spec.rb b/spec/features/admin/configuration/mail_methods_spec.rb index acdb60d527..834b3dabe7 100644 --- a/spec/features/admin/configuration/mail_methods_spec.rb +++ b/spec/features/admin/configuration/mail_methods_spec.rb @@ -15,7 +15,7 @@ describe "Mail Methods" do end it "should be able to edit mail method settings" do - fill_in "mail_bcc", :with => "spree@example.com99" + fill_in "mail_bcc", with: "spree@example.com99" click_button "Update" expect(page).to have_content("successfully updated!") end