From bed2fe69f6652d767e90488f48dbf745fb311a67 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 7 Jun 2023 16:39:37 +0100
Subject: [PATCH] Update regression tests

---
 spec/models/spree/variant_spec.rb | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/spec/models/spree/variant_spec.rb b/spec/models/spree/variant_spec.rb
index 5fad1dcb28..c22fc3dd00 100644
--- a/spec/models/spree/variant_spec.rb
+++ b/spec/models/spree/variant_spec.rb
@@ -433,17 +433,28 @@ describe Spree::Variant do
       end
     end
 
-    context "when related naming values are nil" do
-      before do
-        product.name = "Apples"
+    context "handling nil values for related naming attributes" do
+      it "returns empty string or product name" do
+        product.name = "Apple"
+        product.variant_unit = "items"
+        product.display_as = nil
+        variant.display_as = nil
+        variant.display_name = nil
+
+        expect(variant.full_name).to eq ""
+        expect(variant.product_and_full_name).to eq product.name
+      end
+
+      it "uses the display name correctly" do
+        product.name = "Apple"
+        product.variant_unit = "items"
         product.display_as = nil
         variant.display_as = nil
         variant.unit_presentation = nil
-      end
+        variant.display_name = "Green"
 
-      it "returns empty string or product name" do
-        expect(variant.full_name).to eq ""
-        expect(variant.product_and_full_name).to eq product.name
+        expect(variant.full_name).to eq "Green"
+        expect(variant.product_and_full_name).to eq "Apple - Green"
       end
     end
   end