From be6481dac3ebfb65e8303671c5adf9fdc1bfab39 Mon Sep 17 00:00:00 2001
From: David Cook <david@redcliffs.net>
Date: Wed, 20 Sep 2023 16:42:16 +1000
Subject: [PATCH] Refactor spec: combine expectations

These expectations have the same conditions, so why set it up three times?
---
 spec/services/sets/product_set_spec.rb | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/spec/services/sets/product_set_spec.rb b/spec/services/sets/product_set_spec.rb
index 536e720c3e..2a8b913730 100644
--- a/spec/services/sets/product_set_spec.rb
+++ b/spec/services/sets/product_set_spec.rb
@@ -56,22 +56,14 @@ describe Sets::ProductSet do
             }
           end
 
-          it 'updates the product' do
-            product_set.save
+          it 'updates the product without error' do
+            expect(product_set.save).to eq true
 
             expect(product.reload.attributes).to include(
               'variant_unit' => 'weight'
             )
-          end
 
-          it 'does not add an error' do
-            product_set.save
-            expect(product_set.errors)
-              .to be_empty
-          end
-
-          it 'returns true' do
-            expect(product_set.save).to eq(true)
+            expect(product_set.errors).to be_empty
           end
         end