From bde46fa1e9dc20e963620f5b8a8174a6d097e202 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Wed, 19 Apr 2023 15:29:00 +1000 Subject: [PATCH] Safely autocorrect Gemspec/DeprecatedAttributeAssignment Inspecting 1404 files .............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: engines/catalog/catalog.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec. s.test_files = Dir["test/**/*"] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/dfc_provider/dfc_provider.gemspec:17:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec. spec.test_files = Dir['spec/**/*'] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/order_management/order_management.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec. s.test_files = Dir["spec/**/*"] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/web/web.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec. s.test_files = Dir["test/**/*"] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1404 files inspected, 4 offenses detected, 4 offenses corrected --- .rubocop_todo.yml | 13 +------------ engines/catalog/catalog.gemspec | 1 - engines/dfc_provider/dfc_provider.gemspec | 1 - engines/order_management/order_management.gemspec | 1 - engines/web/web.gemspec | 1 - 5 files changed, 1 insertion(+), 16 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 03c317ee30..5ff9310171 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,22 +1,11 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400` -# on 2023-04-19 05:26:36 UTC using RuboCop version 1.50.2. +# on 2023-04-19 05:28:26 UTC using RuboCop version 1.50.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 4 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: Severity, Include. -# Include: **/*.gemspec -Gemspec/DeprecatedAttributeAssignment: - Exclude: - - 'engines/catalog/catalog.gemspec' - - 'engines/dfc_provider/dfc_provider.gemspec' - - 'engines/order_management/order_management.gemspec' - - 'engines/web/web.gemspec' - # Offense count: 4 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: Severity, Include. diff --git a/engines/catalog/catalog.gemspec b/engines/catalog/catalog.gemspec index a20f6d0e04..846a0ddbfd 100644 --- a/engines/catalog/catalog.gemspec +++ b/engines/catalog/catalog.gemspec @@ -11,5 +11,4 @@ Gem::Specification.new do |s| s.summary = "Catalog domain of the OFN solution." s.files = Dir["{app,config,db,lib}/**/*"] + ["LICENSE.txt", "Rakefile", "README.rdoc"] - s.test_files = Dir["test/**/*"] end diff --git a/engines/dfc_provider/dfc_provider.gemspec b/engines/dfc_provider/dfc_provider.gemspec index e5f306fc53..10c5551a29 100644 --- a/engines/dfc_provider/dfc_provider.gemspec +++ b/engines/dfc_provider/dfc_provider.gemspec @@ -14,7 +14,6 @@ Gem::Specification.new do |spec| 'specifications' spec.files = Dir["{app,config,lib}/**/*"] + ['README.md'] - spec.test_files = Dir['spec/**/*'] spec.add_dependency 'active_model_serializers', '~> 0.8.4' spec.add_dependency 'jwt', '~> 2.2' diff --git a/engines/order_management/order_management.gemspec b/engines/order_management/order_management.gemspec index a5ff6759bc..20c6bad154 100644 --- a/engines/order_management/order_management.gemspec +++ b/engines/order_management/order_management.gemspec @@ -11,5 +11,4 @@ Gem::Specification.new do |s| s.summary = "Order Management domain of the OFN solution." s.files = Dir["{app,config,db,lib}/**/*"] + ["LICENSE.txt", "Rakefile", "README.rdoc"] - s.test_files = Dir["spec/**/*"] end diff --git a/engines/web/web.gemspec b/engines/web/web.gemspec index ebc9d4d1e7..2cbef7f50f 100644 --- a/engines/web/web.gemspec +++ b/engines/web/web.gemspec @@ -11,5 +11,4 @@ Gem::Specification.new do |s| s.summary = "Web domain of the OFN solution." s.files = Dir["{app,config,db,lib}/**/*"] + ["LICENSE.txt", "Rakefile", "README.rdoc"] - s.test_files = Dir["test/**/*"] end