raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-04-07 07:36:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enforce RSpec expect(..).not_to over to_not

Browse Source
This commit is contained in:
Maikel Linke
2024-03-07 16:57:54 +11:00
parent b4385623b2
commit bd6b0ddbf3
163 changed files with 616 additions and 613 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/controllers/spree/admin/adjustments_controller_spec.rb
View File

@@ -27,7 +27,7 @@ module Spree
spree_get :index, order_id: order.number
expect(assigns(:collection)).to include adjustment1, adjustment2
expect(assigns(:collection)).to_not include adjustment3
expect(assigns(:collection)).not_to include adjustment3
end
it "displays admin adjustments" do
@@ -39,7 +39,7 @@ module Spree
it "does not display enterprise fee adjustments" do
spree_get :index, order_id: order.number
expect(assigns(:collection)).to_not include adjustment4
expect(assigns(:collection)).not_to include adjustment4
end
end
@@ -237,7 +237,7 @@ module Spree
expect {
spree_post :create, order_id: order.number,
adjustment: { label: "Testing", amount: "110" }
}.to_not change { [Adjustment.count, order.reload.total] }
}.not_to change { [Adjustment.count, order.reload.total] }
expect(response).to redirect_to spree.admin_order_adjustments_path(order)
end
@@ -246,7 +246,7 @@ module Spree
expect {
spree_put :update, order_id: order.number, id: adjustment.id,
adjustment: { label: "Testing", amount: "110" }
}.to_not change { [adjustment.reload.amount, order.reload.total] }
}.not_to change { [adjustment.reload.amount, order.reload.total] }
expect(response).to redirect_to spree.admin_order_adjustments_path(order)
end

2
spec/controllers/spree/admin/general_settings_controller_spec.rb
View File

@@ -13,7 +13,7 @@ describe Spree::Admin::GeneralSettingsController, type: :controller do
end
it "updates available units" do
expect(Spree::Config.available_units).to_not include("lb")
expect(Spree::Config.available_units).not_to include("lb")
settings_params = { available_units: { lb: "1" } }
spree_put :update, settings_params
expect(Spree::Config.available_units).to include("lb")

2
spec/controllers/spree/admin/orders/invoices_spec.rb
View File

@@ -40,7 +40,7 @@ describe Spree::Admin::OrdersController, type: :controller do
it "should allow me to send order invoices" do
expect do
spree_get :invoice, params
end.to_not change{ Spree::OrderMailer.deliveries.count }
end.not_to change{ Spree::OrderMailer.deliveries.count }
expect(response).to redirect_to spree.edit_admin_order_path(order)
expect(flash[:error])
.to eq "#{distributor.name} must have a valid ABN before invoices can be used."

16
spec/controllers/spree/admin/orders/payments/payments_controller_refunds_spec.rb
View File

@@ -49,13 +49,13 @@ describe Spree::Admin::PaymentsController, type: :controller do
it "voids the payment" do
order.reload
expect(order.payment_total).to_not eq 0
expect(order.payment_total).not_to eq 0
expect(order.outstanding_balance.to_f).to eq 0
spree_put :fire, params
expect(payment.reload.state).to eq 'void'
order.reload
expect(order.payment_total).to eq 0
expect(order.outstanding_balance.to_f).to_not eq 0
expect(order.outstanding_balance.to_f).not_to eq 0
end
end
@@ -69,12 +69,12 @@ describe Spree::Admin::PaymentsController, type: :controller do
it "does not void the payment" do
order.reload
expect(order.payment_total).to_not eq 0
expect(order.payment_total).not_to eq 0
expect(order.outstanding_balance.to_f).to eq 0
spree_put :fire, params
expect(payment.reload.state).to eq 'completed'
order.reload
expect(order.payment_total).to_not eq 0
expect(order.payment_total).not_to eq 0
expect(order.outstanding_balance.to_f).to eq 0
expect(flash[:error]).to eq "Bup-bow!"
end
@@ -92,13 +92,13 @@ describe Spree::Admin::PaymentsController, type: :controller do
it "can still void the payment" do
order.reload
expect(order.payment_total).to_not eq 0
expect(order.payment_total).not_to eq 0
expect(order.outstanding_balance.to_f).to eq 0
spree_put :fire, params
expect(payment.reload.state).to eq 'void'
order.reload
expect(order.payment_total).to eq 0
expect(order.outstanding_balance.to_f).to_not eq 0
expect(order.outstanding_balance.to_f).not_to eq 0
end
end
end
@@ -115,13 +115,13 @@ describe Spree::Admin::PaymentsController, type: :controller do
it "voids the payment" do
order.reload
expect(order.payment_total).to_not eq 0
expect(order.payment_total).not_to eq 0
expect(order.outstanding_balance.to_f).to eq 0
spree_put :fire, params
expect(payment.reload.state).to eq 'void'
order.reload
expect(order.payment_total).to eq 0
expect(order.outstanding_balance.to_f).to_not eq 0
expect(order.outstanding_balance.to_f).not_to eq 0
end
end
end

2
spec/controllers/spree/admin/orders/payments/payments_controller_spec.rb
View File

@@ -258,7 +258,7 @@ describe Spree::Admin::PaymentsController, type: :controller do
it 'does not process the event' do
spree_put :fire, params
expect(payment).to_not receive(:unrecognized_event)
expect(payment).not_to receive(:unrecognized_event)
expect(flash[:error]).to eq('Could not update the payment')
end
end

4
spec/controllers/spree/admin/orders_controller_spec.rb
View File

@@ -24,7 +24,7 @@ describe Spree::Admin::OrdersController, type: :controller do
spree_get :edit, id: order
expect(response.body).to_not match adjustment.label
expect(response.body).not_to match adjustment.label
end
end
end
@@ -204,7 +204,7 @@ describe Spree::Admin::OrdersController, type: :controller do
order.reload
expect(order.all_adjustments.tax.count).to eq 2
expect(order.all_adjustments.tax).to_not include legacy_tax_adjustment
expect(order.all_adjustments.tax).not_to include legacy_tax_adjustment
expect(order.additional_tax_total).to eq 0.5
end
end

4
spec/controllers/spree/admin/products_controller_spec.rb
View File

@@ -190,7 +190,7 @@ describe Spree::Admin::ProductsController, type: :controller do
spree_put :update, id: product, product: { supplier_id: new_producer.id }
expect(product.reload.supplier.id).to eq new_producer.id
expect(order_cycle.reload.distributed_variants).to_not include product.variants.first
expect(order_cycle.reload.distributed_variants).not_to include product.variants.first
end
end
@@ -227,7 +227,7 @@ describe Spree::Admin::ProductsController, type: :controller do
expect(Spree::Property.count).to be 1
expect(Spree::ProductProperty.count).to be 0
property_names = product.reload.properties.map(&:name)
expect(property_names).to_not include 'a different name'
expect(property_names).not_to include 'a different name'
end
end

2
spec/controllers/spree/admin/search_controller_spec.rb
View File

@@ -18,7 +18,7 @@ describe Spree::Admin::SearchController, type: :controller do
it "returns a list of users that I share management of enteprises with" do
expect(assigns(:users)).to include owner, manager
expect(assigns(:users)).to_not include random
expect(assigns(:users)).not_to include random
end
end

2
spec/controllers/spree/admin/tax_rates_controller_spec.rb
View File

@@ -27,7 +27,7 @@ module Spree
it "updates the record" do
expect {
spree_put :update, id: tax_rate.id, tax_rate: params
}.to_not change{ Spree::TaxRate.with_deleted.count }
}.not_to change{ Spree::TaxRate.with_deleted.count }
expect(response).to redirect_to spree.admin_tax_rates_url
expect(tax_rate.reload.name).to eq "Updated Rate"