From bd0db57768e1abdaf3442d805d414d4fc9c35be2 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Mon, 3 Nov 2025 15:58:27 +1100 Subject: [PATCH] Per review, more concise code --- .../spree/admin/payment_methods_controller.rb | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/app/controllers/spree/admin/payment_methods_controller.rb b/app/controllers/spree/admin/payment_methods_controller.rb index 998f48932d..97f77420fd 100644 --- a/app/controllers/spree/admin/payment_methods_controller.rb +++ b/app/controllers/spree/admin/payment_methods_controller.rb @@ -10,6 +10,12 @@ module Spree respond_to :html + PAYMENT_METHODS = %w{ + Spree::PaymentMethod::Check + Spree::Gateway::PayPalExpress + Spree::Gateway::StripeSCA + }.index_with(&:constantize).freeze + def create force_environment @@ -89,11 +95,7 @@ module Spree @payment_method = PaymentMethod.find(params[:pm_id]) end else - @payment_method = if allowed_payment_methods.include?(params[:provider_type]) - params[:provider_type].constantize.new - else - PaymentMethod.new - end + @payment_method = PAYMENT_METHODS.fetch(params[:provider_type], PaymentMethod).new end render partial: 'provider_settings' @@ -207,10 +209,6 @@ module Spree def add_type_to_calculator_attributes(hash) hash["calculator_attributes"]["type"] = hash["calculator_type"] end - - def allowed_payment_methods - %w{Spree::PaymentMethod::Check Spree::Gateway::PayPalExpress Spree::Gateway::StripeSCA} - end end end end