From babe2247a57d6fd81178418f2d534e73f6468ac1 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 8 Nov 2019 19:08:13 +1100 Subject: [PATCH] Put new violations on the todo list --- .rubocop_manual_todo.yml | 2 + .rubocop_todo.yml | 209 +++++++++++++++++++++++++++++++++++++-- 2 files changed, 201 insertions(+), 10 deletions(-) diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index d5a64720cb..7b910d6f7b 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -495,6 +495,8 @@ Metrics/AbcSize: - lib/spree/api/controller_setup.rb - spec/features/consumer/shopping/checkout_paypal_spec.rb - spec/services/restart_checkout_spec.rb + - app/helpers/spree/admin/navigation_helper_decorator.rb + - app/serializers/api/admin/order_cycle_serializer.rb Metrics/BlockLength: Max: 25 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 91c9291ff9..7d58250732 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,12 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 1400` -# on 2019-11-08 18:54:42 +1100 using RuboCop version 0.57.2. +# on 2019-11-08 19:04:56 +1100 using RuboCop version 0.68.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 1 +# Offense count: 81 # Cop supports --auto-correct. # Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. # SupportedHashRocketStyles: key, separator, table @@ -14,7 +14,24 @@ # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit Layout/AlignHash: Exclude: + - 'app/helpers/admin/injection_helper.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_group.rb' + - 'lib/open_food_network/address_finder.rb' + - 'lib/open_food_network/column_preference_defaults.rb' + - 'spec/controllers/spree/admin/image_settings_controller_spec.rb' + - 'spec/features/admin/image_settings_spec.rb' - 'spec/mailers/order_mailer_spec.rb' + - 'spec/models/column_preference_spec.rb' + +# Offense count: 5 +# Cop supports --auto-correct. +Layout/BlockEndNewline: + Exclude: + - 'lib/open_food_network/users_and_enterprises_report.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' + - 'spec/models/column_preference_spec.rb' + - 'spec/services/subscription_form_spec.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -24,6 +41,131 @@ Layout/DefEndAlignment: Exclude: - 'app/models/order_updater.rb' +# Offense count: 233 +# Cop supports --auto-correct. +Layout/EmptyLineAfterGuardClause: + Exclude: + - 'app/controllers/admin/customers_controller.rb' + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/admin/product_import_controller.rb' + - 'app/controllers/admin/schedules_controller.rb' + - 'app/controllers/admin/stripe_accounts_controller.rb' + - 'app/controllers/admin/stripe_connect_settings_controller.rb' + - 'app/controllers/admin/subscription_line_items_controller.rb' + - 'app/controllers/admin/subscriptions_controller.rb' + - 'app/controllers/api/base_controller.rb' + - 'app/controllers/api/enterprise_attachment_controller.rb' + - 'app/controllers/api/taxons_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/enterprises_controller.rb' + - 'app/controllers/line_items_controller.rb' + - 'app/controllers/spree/admin/base_controller_decorator.rb' + - 'app/controllers/spree/admin/general_settings_controller.rb' + - 'app/controllers/spree/admin/mail_methods_controller.rb' + - 'app/controllers/spree/admin/orders/customer_details_controller_decorator.rb' + - 'app/controllers/spree/admin/payment_methods_controller_decorator.rb' + - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/controllers/spree/admin/shipping_methods_controller.rb' + - 'app/controllers/spree/admin/users_controller.rb' + - 'app/controllers/spree/credit_cards_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + - 'app/controllers/spree/paypal_controller_decorator.rb' + - 'app/helpers/admin/subscriptions_helper.rb' + - 'app/helpers/angular_form_builder.rb' + - 'app/helpers/enterprises_helper.rb' + - 'app/helpers/groups_helper.rb' + - 'app/helpers/serializer_helper.rb' + - 'app/helpers/spree/admin/navigation_helper_decorator.rb' + - 'app/helpers/spree/admin/orders_helper_decorator.rb' + - 'app/helpers/spree/orders_helper.rb' + - 'app/jobs/subscription_confirm_job.rb' + - 'app/mailers/producer_mailer.rb' + - 'app/models/column_preference.rb' + - 'app/models/concerns/order_shipment.rb' + - 'app/models/concerns/product_stock.rb' + - 'app/models/customer.rb' + - 'app/models/enterprise_group.rb' + - 'app/models/order_cycle.rb' + - 'app/models/order_updater.rb' + - 'app/models/product_import/entry_validator.rb' + - 'app/models/product_import/product_importer.rb' + - 'app/models/product_import/reset_absent.rb' + - 'app/models/product_import/spreadsheet_data.rb' + - 'app/models/proxy_order.rb' + - 'app/models/spree/calculator/per_item_decorator.rb' + - 'app/models/spree/credit_card_decorator.rb' + - 'app/models/spree/gateway/stripe_connect.rb' + - 'app/models/spree/line_item_decorator.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/payment_decorator.rb' + - 'app/models/spree/product_decorator.rb' + - 'app/models/spree/product_set.rb' + - 'app/models/spree/shipment_decorator.rb' + - 'app/models/spree/tax_rate_decorator.rb' + - 'app/models/spree/user.rb' + - 'app/models/spree/variant_decorator.rb' + - 'app/models/subscription.rb' + - 'app/models/tag_rule/discount_order.rb' + - 'app/serializers/api/admin/customer_serializer.rb' + - 'app/serializers/api/admin/index_enterprise_serializer.rb' + - 'app/serializers/api/admin/line_item_serializer.rb' + - 'app/serializers/api/admin/order_serializer.rb' + - 'app/serializers/api/admin/product_serializer.rb' + - 'app/serializers/api/admin/proxy_order_serializer.rb' + - 'app/serializers/api/admin/subscription_serializer.rb' + - 'app/serializers/api/admin/variant_serializer.rb' + - 'app/serializers/api/cached_enterprise_serializer.rb' + - 'app/serializers/api/enterprise_shopfront_serializer.rb' + - 'app/serializers/api/order_serializer.rb' + - 'app/serializers/api/variant_serializer.rb' + - 'app/services/advance_order_service.rb' + - 'app/services/embedded_page_service.rb' + - 'app/services/exchange_variant_bulk_updater.rb' + - 'app/services/order_cycle_distributed_variants.rb' + - 'app/services/order_cycle_form.rb' + - 'app/services/order_factory.rb' + - 'app/services/order_syncer.rb' + - 'app/services/product_tag_rules_filterer.rb' + - 'app/services/search_orders.rb' + - 'app/services/subscription_estimator.rb' + - 'app/services/subscription_form.rb' + - 'app/services/subscription_validator.rb' + - 'app/services/subscriptions_count.rb' + - 'app/services/tax_rate_finder.rb' + - 'engines/order_management/app/services/order_management/reports/enterprise_fee_summary/data_representations/coordinator_fee.rb' + - 'engines/order_management/app/services/order_management/reports/enterprise_fee_summary/summarizer.rb' + - 'lib/open_food_network/address_finder.rb' + - 'lib/open_food_network/bulk_coop_report.rb' + - 'lib/open_food_network/customers_report.rb' + - 'lib/open_food_network/enterprise_issue_validator.rb' + - 'lib/open_food_network/lettuce_share_report.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' + - 'lib/open_food_network/packing_report.rb' + - 'lib/open_food_network/payments_report.rb' + - 'lib/open_food_network/permalink_generator.rb' + - 'lib/open_food_network/permissions.rb' + - 'lib/open_food_network/products_and_inventory_report.rb' + - 'lib/open_food_network/proxy_order_syncer.rb' + - 'lib/open_food_network/sales_tax_report.rb' + - 'lib/open_food_network/subscription_payment_updater.rb' + - 'lib/open_food_network/subscription_summarizer.rb' + - 'lib/open_food_network/tag_rule_applicator.rb' + - 'lib/open_food_network/users_and_enterprises_report.rb' + - 'lib/open_food_network/variant_and_line_item_naming.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'lib/spree/localized_number.rb' + - 'lib/stripe/webhook_handler.rb' + - 'lib/tasks/data.rake' + - 'lib/tasks/karma.rake' + - 'lib/tasks/sample_data/customer_factory.rb' + - 'lib/tasks/sample_data/fee_factory.rb' + - 'lib/tasks/sample_data/payment_method_factory.rb' + - 'lib/tasks/sample_data/shipping_method_factory.rb' + - 'lib/tasks/sample_data/taxon_factory.rb' + - 'spec/factories/product_factory.rb' + - 'spec/support/request/web_helper.rb' + # Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. @@ -45,7 +187,7 @@ Layout/EndAlignment: # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. +# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. Layout/ExtraSpacing: Exclude: - 'spec/services/order_syncer_spec.rb' @@ -57,6 +199,20 @@ Layout/ExtraSpacing: Layout/IndentFirstHashElement: EnforcedStyle: consistent +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: aligned, indented, indented_relative_to_receiver +Layout/MultilineMethodCallIndentation: + Exclude: + - 'app/models/product_import/entry_validator.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/RescueEnsureAlignment: + Exclude: + - 'app/controllers/spree/admin/reports_controller_decorator.rb' + # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment. @@ -132,6 +288,7 @@ Lint/ShadowingOuterLocalVariable: - 'spec/models/model_set_spec.rb' # Offense count: 2 +# Configuration parameters: AllowKeywordBlockArguments. Lint/UnderscorePrefixedVariableName: Exclude: - 'spec/support/cancan_helper.rb' @@ -158,6 +315,10 @@ Lint/Void: Exclude: - 'app/serializers/api/enterprise_serializer.rb' +# Offense count: 2 +Metrics/AbcSize: + Max: 16 + # Offense count: 8 Naming/AccessorMethodName: Exclude: @@ -175,6 +336,8 @@ Naming/HeredocDelimiterNaming: - 'app/models/content_configuration.rb' # Offense count: 4 +# Configuration parameters: EnforcedStyleForLeadingUnderscores. +# SupportedStylesForLeadingUnderscores: disallowed, required, optional Naming/MemoizedInstanceVariableName: Exclude: - 'app/controllers/spree/admin/payments_controller_decorator.rb' @@ -207,9 +370,20 @@ Naming/PredicateName: - 'lib/open_food_network/packing_report.rb' - 'lib/tasks/data.rake' +# Offense count: 5 +# Cop supports --auto-correct. +# Configuration parameters: PreferredName. +Naming/RescuedExceptionsVariableName: + Exclude: + - 'app/controllers/spree/admin/payments_controller_decorator.rb' + - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/controllers/user_registrations_controller.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/product_set.rb' + # Offense count: 11 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. -# AllowedNames: io, id, to, by, on, in, at +# AllowedNames: io, id, to, by, on, in, at, ip, db Naming/UncommunicativeMethodParamName: Exclude: - 'app/helpers/admin/injection_helper.rb' @@ -299,6 +473,12 @@ Rails/HttpStatus: - 'app/controllers/api/products_controller.rb' - 'app/controllers/api/variants_controller.rb' +# Offense count: 1 +# Cop supports --auto-correct. +Rails/LinkToBlank: + Exclude: + - 'app/helpers/footer_links_helper.rb' + # Offense count: 6 Rails/OutputSafety: Exclude: @@ -309,7 +489,16 @@ Rails/OutputSafety: - 'lib/spree/money_decorator.rb' - 'spec/features/admin/orders_spec.rb' +# Offense count: 9 +Rails/ReflectionClassName: + Exclude: + - 'app/models/customer.rb' + - 'app/models/distributor_shipping_method.rb' + - 'app/models/enterprise_role.rb' + - 'app/models/subscription.rb' + # Offense count: 11 +# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: @@ -443,11 +632,6 @@ Style/ConditionalAssignment: - 'app/controllers/api/variants_controller.rb' - 'app/controllers/spree/admin/taxons_controller.rb' -# Offense count: 2 -Style/DateTime: - Exclude: - - 'lib/open_food_network/users_and_enterprises_report.rb' - # Offense count: 5 # Configuration parameters: EnforcedStyle. # SupportedStyles: annotated, template, unannotated @@ -529,9 +713,14 @@ Style/MixinUsage: - 'spec/lib/open_food_network/order_cycle_management_report_spec.rb' - 'spec/lib/open_food_network/packing_report_spec.rb' +# Offense count: 1 +Style/MultipleComparison: + Exclude: + - 'spec/models/product_importer_spec.rb' + # Offense count: 9 # Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, EnforcedStyle. +# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison Style/NumericPredicate: Exclude: