From 99a4be134b8fb803edede3c86c1d70dccebe0dca Mon Sep 17 00:00:00 2001 From: Shen Sat Date: Tue, 25 May 2021 08:55:49 +0100 Subject: [PATCH 1/2] Add delete action test to ShippingCategoriesController spec --- .../spree/admin/shipping_categories_controller_spec.rb | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/spec/controllers/spree/admin/shipping_categories_controller_spec.rb b/spec/controllers/spree/admin/shipping_categories_controller_spec.rb index 05aefff048..0a0fcbd6ac 100644 --- a/spec/controllers/spree/admin/shipping_categories_controller_spec.rb +++ b/spec/controllers/spree/admin/shipping_categories_controller_spec.rb @@ -26,6 +26,15 @@ module Spree expect(response).to redirect_to spree.admin_shipping_categories_url expect(shipping_category.reload.name).to eq "Super Frozen" end + + it "deletes an existing shipping category" do + shipping_category = create(:shipping_category) + expect { + spree_delete :destroy, id: shipping_category.id + }.to change(Spree::ShippingCategory.all, :count).by(-1) + + expect(response).to redirect_to spree.admin_shipping_categories_url + end end end end From 80ae211b72e6956e94dc4ec16e9e99442b2ad1e8 Mon Sep 17 00:00:00 2001 From: Shen Date: Tue, 1 Jun 2021 20:51:10 +0100 Subject: [PATCH 2/2] Use correct syntax for `change` matcher in spec/controllers/spree/admin/shipping_categories_controller_spec.rb Co-authored-by: Maikel --- .../spree/admin/shipping_categories_controller_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/controllers/spree/admin/shipping_categories_controller_spec.rb b/spec/controllers/spree/admin/shipping_categories_controller_spec.rb index 0a0fcbd6ac..8a77bb78c6 100644 --- a/spec/controllers/spree/admin/shipping_categories_controller_spec.rb +++ b/spec/controllers/spree/admin/shipping_categories_controller_spec.rb @@ -13,7 +13,7 @@ module Spree it "creates a shipping shipping category" do expect { spree_post :create, shipping_category: { name: "Frozen" } - }.to change(Spree::ShippingCategory.all, :count).by(1) + }.to change { Spree::ShippingCategory.count }.by(1) expect(response).to redirect_to spree.admin_shipping_categories_url end @@ -31,7 +31,7 @@ module Spree shipping_category = create(:shipping_category) expect { spree_delete :destroy, id: shipping_category.id - }.to change(Spree::ShippingCategory.all, :count).by(-1) + }.to change { Spree::ShippingCategory.count }.by(-1) expect(response).to redirect_to spree.admin_shipping_categories_url end