From b84707edd99e41cf586ed48ca66502a8809acdae Mon Sep 17 00:00:00 2001 From: Ryan Murphy Date: Sat, 2 Dec 2023 13:09:34 -0500 Subject: [PATCH] Cleanse JS errors from DOM on Stripe failure --- .../javascripts/admin/payments/services/payment.js.coffee | 3 ++- spec/system/admin/payments_spec.rb | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/admin/payments/services/payment.js.coffee b/app/assets/javascripts/admin/payments/services/payment.js.coffee index 487dafcd03..ea40e12f96 100644 --- a/app/assets/javascripts/admin/payments/services/payment.js.coffee +++ b/app/assets/javascripts/admin/payments/services/payment.js.coffee @@ -43,7 +43,8 @@ angular.module('admin.payments').factory 'Payment', (AdminStripeElements, curren submit: => munged = @preprocess() PaymentResource.create({order_id: munged.order_id}, munged, (response, headers, status) -> - document.body.innerHTML = Object.values(response).join('') + rawHtml = Object.values(response).join('').replace('[object Object]true', '') + document.body.innerHTML = rawHtml $window.history.pushState({}, '', "/admin/orders/" + munged.order_id + "/payments") , (response) -> StatusMessage.display 'error', t("spree.admin.payments.source_forms.stripe.error_saving_payment") diff --git a/spec/system/admin/payments_spec.rb b/spec/system/admin/payments_spec.rb index f34c35e6bc..e648c5698f 100644 --- a/spec/system/admin/payments_spec.rb +++ b/spec/system/admin/payments_spec.rb @@ -62,6 +62,7 @@ describe ' click_button "Update" expect(page).to have_content "Payments" expect(page).to have_content "Payment has been successfully created!" + expect(page).not_to have_content "[object Object]true" order.reload expect(order.state).to eq "complete"