From b6bfb4e866a900c9f2d7c66ef8095f80a4116dad Mon Sep 17 00:00:00 2001 From: wandji20 Date: Thu, 22 Aug 2024 22:21:17 +0100 Subject: [PATCH] Refactor order cycle same_dates method --- app/models/order_cycle.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/order_cycle.rb b/app/models/order_cycle.rb index 7e0c3d6646..dd234d81f7 100644 --- a/app/models/order_cycle.rb +++ b/app/models/order_cycle.rb @@ -315,7 +315,7 @@ class OrderCycle < ApplicationRecord def same_datetime_value(attribute, string) return true if self[attribute].blank? && string.blank? - return false if [[attribute].present?, string.present?].include?(false) + return false if self[attribute].blank? || string.blank? DateTime.parse(string).to_fs(:short) == self[attribute]&.to_fs(:short) end