From b60eeb8dc44ec6442ff10441722dbd7e51824bb8 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Fri, 15 Apr 2022 14:36:42 +0200 Subject: [PATCH] Exclude ViewComponents from MissingSuper rule as it's unnecessary Source: https://viewcomponent.org/#whats-a-viewcomponent --- .rubocop_styleguide.yml | 4 ++++ .rubocop_todo.yml | 5 ----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.rubocop_styleguide.yml b/.rubocop_styleguide.yml index 1cf9623b42..b1b1eb33c4 100644 --- a/.rubocop_styleguide.yml +++ b/.rubocop_styleguide.yml @@ -105,6 +105,10 @@ Lint/UselessAssignment: Exclude: - spec/**/* +Lint/MissingSuper: + Exclude: + - 'app/components/**/*' + Metrics/AbcSize: Max: 30 # default 17 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d796055b5f..ac90405d33 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -366,11 +366,6 @@ Lint/IneffectiveAccessModifier: Exclude: - 'app/models/spree/user.rb' -# Offense count: 2 -Lint/MissingSuper: - Exclude: - - 'app/components/distributor_title_component.rb' - - 'app/components/example_component.rb' # Offense count: 1 # Cop supports --auto-correct.