From b593e356b05380bb4e45c02cacc7584bb40d6067 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Mon, 3 Jul 2023 17:17:20 +0100
Subject: [PATCH] Update product factories

---
 spec/factories/product_factory.rb | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/spec/factories/product_factory.rb b/spec/factories/product_factory.rb
index f09e46bb96..06a7aef77c 100644
--- a/spec/factories/product_factory.rb
+++ b/spec/factories/product_factory.rb
@@ -26,9 +26,6 @@ FactoryBot.define do
     factory :product do
       transient do
         on_hand { 5 }
-      end
-
-      transient do
         tax_category { |r| Spree::TaxCategory.first || r.association(:tax_category) }
       end
 
@@ -69,7 +66,7 @@ FactoryBot.define do
       tax_category { create(:tax_category) }
     end
 
-    after(:create) do |_product, proxy|
+    after(:create) do |product, proxy|
       raise "taxed_product factory requires a zone" unless proxy.zone
 
       create(:tax_rate, amount: proxy.tax_rate_amount,
@@ -78,6 +75,8 @@ FactoryBot.define do
                         calculator: Calculator::DefaultTax.new,
                         zone: proxy.zone,
                         name: proxy.tax_rate_name)
+
+      product.variants.first.update(tax_category: proxy.tax_category)
     end
   end
 end