From c5a2d183d864a3c3f0ef8c42bdddf8fa2246fe12 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Thu, 20 May 2021 15:12:24 +0200
Subject: [PATCH 01/15] Save filter params to sessionStorage for orders list

 - Use sessionStorage to save the filters params each time a filter is modified
---
 .../javascripts/admin/admin_ofn.js.coffee     |  3 ++-
 app/assets/javascripts/admin/all.js           |  3 +++
 .../controllers/orders_controller.js.coffee   | 17 ++++++++----
 .../javascripts/admin/orders/orders.js.coffee |  2 +-
 .../services/query_persistence.js.coffee      | 27 +++++++++++++++++++
 .../javascripts/shared/shared.js.coffee       |  3 ++-
 app/views/spree/admin/orders/edit.html.haml   | 10 +++++--
 7 files changed, 55 insertions(+), 10 deletions(-)
 create mode 100644 app/assets/javascripts/admin/services/query_persistence.js.coffee

diff --git a/app/assets/javascripts/admin/admin_ofn.js.coffee b/app/assets/javascripts/admin/admin_ofn.js.coffee
index bca7364525..92aa108402 100644
--- a/app/assets/javascripts/admin/admin_ofn.js.coffee
+++ b/app/assets/javascripts/admin/admin_ofn.js.coffee
@@ -8,6 +8,7 @@ angular.module("ofn.admin", [
   "admin.dropdown",
   "admin.products",
   "admin.taxons",
-  "infinite-scroll"
+  "infinite-scroll",
+  "admin.orders"
 ]).config ($httpProvider) ->
   $httpProvider.defaults.headers.common["Accept"] = "application/json, text/javascript, */*"
diff --git a/app/assets/javascripts/admin/all.js b/app/assets/javascripts/admin/all.js
index f28f55565a..8b462886ad 100644
--- a/app/assets/javascripts/admin/all.js
+++ b/app/assets/javascripts/admin/all.js
@@ -110,5 +110,8 @@
 // foundation
 //= require ../shared/mm-foundation-tpls-0.9.0-20180826174721.min.js
 
+// LocalStorage
+//= require ../shared/angular-local-storage.js
+
 // requires the rest of the JS code in this folder
 //= require_tree .
diff --git a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
index 4afb7c1c22..a449431165 100644
--- a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
+++ b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
@@ -1,4 +1,4 @@
-angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, RequestMonitor, Orders, SortOptions, $window, $filter) ->
+angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, RequestMonitor, Orders, SortOptions, $window, $filter, $location, QueryPersistence) ->
   $scope.RequestMonitor = RequestMonitor
   $scope.pagination = Orders.pagination
   $scope.orders = Orders.all
@@ -15,11 +15,16 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
   $scope.poll = 0
   $scope.rowStatus = {}
 
+  QueryPersistence.storageKey = 'ordersFilters'
+  QueryPersistence.storableFilters = ["q", "sorting", "shipping_method_id", "page", "per_page"]
+
   $scope.initialise = ->
-    $scope.per_page = 15
-    $scope.q = {
-      completed_at_not_null: true
-    }
+    unless QueryPersistence.restoreFilters($scope)
+      $scope.per_page = 15
+      $scope.q = {
+        completed_at_not_null: true
+      }
+
     $scope.fetchResults()
 
   $scope.fetchResults = (page=1) ->
@@ -44,10 +49,12 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
       per_page: $scope.per_page,
       page: page
     }
+    QueryPersistence.setStoredFilters($scope)
     RequestMonitor.load(Orders.index(params).$promise)
 
   $scope.appendStringIfNotEmpty = (baseString, stringToAppend) ->
     return baseString unless baseString
+    return baseString if baseString.endsWith(stringToAppend)
 
     baseString + stringToAppend
 
diff --git a/app/assets/javascripts/admin/orders/orders.js.coffee b/app/assets/javascripts/admin/orders/orders.js.coffee
index 1a8b267d30..ee7cd29837 100644
--- a/app/assets/javascripts/admin/orders/orders.js.coffee
+++ b/app/assets/javascripts/admin/orders/orders.js.coffee
@@ -1 +1 @@
-angular.module("admin.orders", ['admin.indexUtils', 'ngResource', 'mm.foundation'])
+angular.module("admin.orders", ['admin.indexUtils', 'ngResource', 'mm.foundation', "OFNShared"])
diff --git a/app/assets/javascripts/admin/services/query_persistence.js.coffee b/app/assets/javascripts/admin/services/query_persistence.js.coffee
new file mode 100644
index 0000000000..1930160fbe
--- /dev/null
+++ b/app/assets/javascripts/admin/services/query_persistence.js.coffee
@@ -0,0 +1,27 @@
+angular.module("admin.indexUtils").factory 'QueryPersistence', (localStorageService)->
+  new class QueryPersistence
+    storageKey: ''
+    storableFilters: []
+
+    constructor: ->
+      localStorageService.setStorageType("sessionStorage")
+
+    getStoredFilters: ->
+      localStorageService.get(@storageKey) || {}
+
+    setStoredFilters: (scope) ->
+      filters = {}
+      for key in @storableFilters
+        filters[key] = scope[key]
+      localStorageService.set(@storageKey, filters)
+
+    restoreFilters: (scope) ->
+      storedFilters = @getStoredFilters()
+
+      if storedFilters
+        for k,v of storedFilters
+          scope[k] = v
+
+        return true
+
+      false
diff --git a/app/assets/javascripts/shared/shared.js.coffee b/app/assets/javascripts/shared/shared.js.coffee
index fffd667d1e..089612728e 100644
--- a/app/assets/javascripts/shared/shared.js.coffee
+++ b/app/assets/javascripts/shared/shared.js.coffee
@@ -1,4 +1,5 @@
 window.OFNShared = angular.module("OFNShared", [
-  "mm.foundation"
+  "mm.foundation",
+  "LocalStorageModule"
 ]).config ($httpProvider) ->
   $httpProvider.defaults.headers.common["Accept"] = "application/json, text/javascript, */*"
diff --git a/app/views/spree/admin/orders/edit.html.haml b/app/views/spree/admin/orders/edit.html.haml
index f86d2f6c1f..d5be74c809 100644
--- a/app/views/spree/admin/orders/edit.html.haml
+++ b/app/views/spree/admin/orders/edit.html.haml
@@ -1,10 +1,16 @@
 = csrf_meta_tags
+
+- content_for :main_ng_app_name do
+  = "ofn.admin"
+
 - content_for :page_actions do
   - if can?(:fire, @order)
     %li= event_links
   = render partial: 'spree/admin/shared/order_links'
   - if can?(:admin, Spree::Order)
-    %li= button_link_to t(:back_to_orders_list), admin_orders_path, :icon => 'icon-arrow-left'
+    %li{"ng-controller" => "ordersCtrl"}
+      %a.button.icon-arrow-left{icon:  'icon-arrow-left', ng: { href: admin_orders_path }}
+        = t(:back_to_orders_list)
 
 = render partial: "spree/admin/shared/order_page_title"
 = render partial: "spree/admin/shared/order_tabs", locals: { current: 'Order Details' }
@@ -17,7 +23,7 @@
 
   = admin_inject_shops(module: 'admin.orders')
   = admin_inject_order_cycles
-  %div{"ng-app" => "admin.orders", "ng-controller" => "orderCtrl", "ofn-distributor-id" => @order.distributor_id, "ofn-order-cycle-id" => @order.order_cycle_id}
+  %div{"ng-controller" => "orderCtrl", "ofn-distributor-id" => @order.distributor_id, "ofn-order-cycle-id" => @order.order_cycle_id}
 
     = render :partial => 'add_product' if can?(:update, @order)
 

From c24ceac0636f9a3acbc0673f9272524eb68a7f8d Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Mon, 3 May 2021 10:49:08 +0100
Subject: [PATCH 02/15] Extract default-setting to comment method

---
 .../orders/controllers/orders_controller.js.coffee    | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
index a449431165..b526001a80 100644
--- a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
+++ b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
@@ -20,13 +20,16 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
 
   $scope.initialise = ->
     unless QueryPersistence.restoreFilters($scope)
-      $scope.per_page = 15
-      $scope.q = {
-        completed_at_not_null: true
-      }
+      $scope.setDefaults()
 
     $scope.fetchResults()
 
+  $scope.setDefaults = ->
+    $scope.per_page = 15
+    $scope.q = {
+      completed_at_not_null: true
+    }
+
   $scope.fetchResults = (page=1) ->
     startDateWithTime = $scope.appendStringIfNotEmpty($scope['q']['completed_at_gteq'], ' 00:00:00')
     endDateWithTime = $scope.appendStringIfNotEmpty($scope['q']['completed_at_lteq'], ' 23:59:59')

From 47404b1dc840d7300bc718d5577d02931c0fa3c0 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Mon, 3 May 2021 13:14:04 +0100
Subject: [PATCH 03/15] Improve handling of nils

---
 .../controllers/orders_controller.js.coffee   | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
index b526001a80..7a53177398 100644
--- a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
+++ b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
@@ -31,22 +31,22 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
     }
 
   $scope.fetchResults = (page=1) ->
-    startDateWithTime = $scope.appendStringIfNotEmpty($scope['q']['completed_at_gteq'], ' 00:00:00')
-    endDateWithTime = $scope.appendStringIfNotEmpty($scope['q']['completed_at_lteq'], ' 23:59:59')
+    startDateWithTime = $scope.appendStringIfNotEmpty($scope.q?.completed_at_gteq, ' 00:00:00')
+    endDateWithTime = $scope.appendStringIfNotEmpty($scope.q?.completed_at_lteq, ' 23:59:59')
 
     $scope.resetSelected()
     params = {
       'q[completed_at_gteq]': startDateWithTime,
       'q[completed_at_lteq]': endDateWithTime,
-      'q[state_eq]': $scope['q']['state_eq'],
-      'q[number_cont]': $scope['q']['number_cont'],
-      'q[email_cont]': $scope['q']['email_cont'],
-      'q[bill_address_firstname_start]': $scope['q']['bill_address_firstname_start'],
-      'q[bill_address_lastname_start]': $scope['q']['bill_address_lastname_start'],
+      'q[state_eq]': $scope.q?.state_eq,
+      'q[number_cont]': $scope.q?.number_cont,
+      'q[email_cont]': $scope.q?.email_cont,
+      'q[bill_address_firstname_start]': $scope.q?.bill_address_firstname_start,
+      'q[bill_address_lastname_start]': $scope.q?.bill_address_lastname_start,
       # Set default checkbox values to null. See: https://github.com/openfoodfoundation/openfoodnetwork/pull/3076#issuecomment-440010498
-      'q[completed_at_not_null]': $scope['q']['completed_at_not_null'] || null,
-      'q[distributor_id_in][]': $scope['q']['distributor_id_in'],
-      'q[order_cycle_id_in][]': $scope['q']['order_cycle_id_in'],
+      'q[completed_at_not_null]': $scope.q?.completed_at_not_null,
+      'q[distributor_id_in][]': $scope.q?.distributor_id_in,
+      'q[order_cycle_id_in][]': $scope.q?.order_cycle_id_in,
       'q[s]': $scope.sorting || 'completed_at desc',
       shipping_method_id: $scope.shipping_method_id,
       per_page: $scope.per_page,

From 93ebfb6a4fd878246d39a81a14ae02c4629d0a6a Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Mon, 3 May 2021 13:15:08 +0100
Subject: [PATCH 04/15] Improve checking for presence of saved filters

---
 .../javascripts/admin/services/query_persistence.js.coffee      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/assets/javascripts/admin/services/query_persistence.js.coffee b/app/assets/javascripts/admin/services/query_persistence.js.coffee
index 1930160fbe..0dad2341f6 100644
--- a/app/assets/javascripts/admin/services/query_persistence.js.coffee
+++ b/app/assets/javascripts/admin/services/query_persistence.js.coffee
@@ -18,7 +18,7 @@ angular.module("admin.indexUtils").factory 'QueryPersistence', (localStorageServ
     restoreFilters: (scope) ->
       storedFilters = @getStoredFilters()
 
-      if storedFilters
+      unless _.isEmpty(storedFilters)
         for k,v of storedFilters
           scope[k] = v
 

From 1674c6a252ecdbcfd1e2cd6c516036053acd3cc8 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Thu, 1 Apr 2021 21:50:31 +0200
Subject: [PATCH 05/15] Improve HTML to improve tests readability

 - Specify `for` attribute to `<label />` element
- Initialize component with its default value

So, it's linked to its `<input />`
---
 app/views/spree/admin/orders/_filters.html.haml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/views/spree/admin/orders/_filters.html.haml b/app/views/spree/admin/orders/_filters.html.haml
index dead6051d9..656fb62e02 100644
--- a/app/views/spree/admin/orders/_filters.html.haml
+++ b/app/views/spree/admin/orders/_filters.html.haml
@@ -15,17 +15,17 @@
             {include_blank: true, class: 'select2', 'ng-model' => 'q.state_eq'})
     .four.columns
       .field
-        = label_tag nil, t(:order_number)
+        = label_tag "q_number_cont", t(:order_number)
         = text_field_tag "q[number_cont]", nil, "ng-model" => "q.number_cont", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
       .field
-        = label_tag nil, t(:email)
+        = label_tag "q_email_cont", t(:email)
         = email_field_tag "q[email_cont", nil, "ng-model" => "q.email_cont", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
     .four.columns
       .field
-        = label_tag nil, t(:first_name_begins_with)
+        = label_tag "q_bill_address_firstname_start", t(:first_name_begins_with)
         = text_field_tag "q[bill_address_firstname_start]", nil, size: 25, "ng-model" => "q.bill_address_firstname_start", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
       .field
-        = label_tag nil, t(:last_name_begins_with)
+        = label_tag "q_bill_address_lastname_start", t(:last_name_begins_with)
         = text_field_tag "q[bill_address_lastname_start]", nil, size: 25, "ng-model" => "q.bill_address_lastname_start", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
     .omega.four.columns
       .field.checkbox
@@ -36,7 +36,7 @@
         = label_tag nil, t(:shipping_method)
         = select_tag("shipping_method_id",
             options_for_select(Spree::ShippingMethod.managed_by(spree_current_user).collect {|s| [t("spree.shipping_method_names.#{s.name}"), s.id]}),
-            {include_blank: true, class: 'select2', 'ng-model' => 'shipping_method_id'})
+            {include_blank: true, class: 'select2', 'ng-model' => 'shipping_method_id', 'ng-value' => 'shipping_method_id'})
     .field-block.alpha.eight.columns
       = label_tag nil, t(:distributors)
       = select_tag("q[distributor_id_in]",

From e388238a25894eeed4ba6a6c40bb62f117d7fecb Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Thu, 20 May 2021 15:22:24 +0200
Subject: [PATCH 06/15] Add tests for saving filter params in Orders list

---
 spec/features/admin/orders_spec.rb | 49 ++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/spec/features/admin/orders_spec.rb b/spec/features/admin/orders_spec.rb
index df9bc5725c..33a2693aec 100644
--- a/spec/features/admin/orders_spec.rb
+++ b/spec/features/admin/orders_spec.rb
@@ -111,4 +111,53 @@ feature '
       expect(page).to have_current_path spree.edit_admin_order_path(incomplete_order)
     end
   end
+
+  context "save the filter params" do
+    scenario "when reloading the page" do
+      user = create(:user, email: 'an@email.com')
+      shipping_method = create(:shipping_method, name: "UPS Ground")
+      order = create(
+        :order,
+        distributor: distributor,
+        order_cycle: order_cycle,
+        user: user,
+        number: "R123456",
+        state: 'complete',
+        payment_state: 'balance_due',
+        completed_at: 1.day.ago
+      )
+
+      login_as_admin_and_visit spree.admin_orders_path
+
+      # Specify each filters
+      uncheck 'Only show complete orders'
+      fill_in "Invoice number", with: "R123456"
+      select2_select order_cycle.name, from: 'q_order_cycle_id_in'
+      select2_select distributor.name, from: 'q_distributor_id_in'
+      select2_select shipping_method.name, from: 'shipping_method_id'
+      select2_select "complete", from: 'q_state_eq'
+      fill_in "Email", with: user.email
+      fill_in "First name begins with", with: "J"
+      fill_in "Last name begins with", with: "D"
+      find('#q_completed_at_gteq').click
+      select_date_from_datepicker Time.zone.at(1.week.ago)
+      find('#q_completed_at_lteq').click
+      select_date_from_datepicker Time.zone.now
+
+      page.find('a.icon-search').click
+
+      page.driver.refresh
+
+      # Check every filters to be equal
+      expect(find_field("Only show complete orders")).not_to be_checked
+      expect(find_field("Invoice number").value).to eq "R123456"
+      expect(find("#s2id_shipping_method_id").text).to eq shipping_method.name
+      expect(find("#s2id_q_state_eq").text).to eq "complete"
+      expect(find_field("Email").value).to eq user.email
+      expect(find_field("First name begins with").value).to eq "J"
+      expect(find_field("Last name begins with").value).to eq "D"
+      expect(find("#q_completed_at_gteq").value).to eq 1.week.ago.strftime("%Y-%m-%d")
+      expect(find("#q_completed_at_lteq").value).to eq Time.now.strftime("%Y-%m-%d")
+    end
+  end
 end

From 4f50afc188fc94c131ec1e1c232842c2aadaeb69 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Fri, 21 May 2021 14:33:44 +0200
Subject: [PATCH 07/15] Change shipping_method_id storage: in the query

---
 .../admin/orders/controllers/orders_controller.js.coffee      | 4 ++--
 app/views/spree/admin/orders/_filters.html.haml               | 3 ++-
 spec/features/admin/orders_spec.rb                            | 4 ++--
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
index 7a53177398..ea0034c405 100644
--- a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
+++ b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
@@ -16,7 +16,7 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
   $scope.rowStatus = {}
 
   QueryPersistence.storageKey = 'ordersFilters'
-  QueryPersistence.storableFilters = ["q", "sorting", "shipping_method_id", "page", "per_page"]
+  QueryPersistence.storableFilters = ["q", "sorting", "page", "per_page"]
 
   $scope.initialise = ->
     unless QueryPersistence.restoreFilters($scope)
@@ -48,7 +48,7 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
       'q[distributor_id_in][]': $scope.q?.distributor_id_in,
       'q[order_cycle_id_in][]': $scope.q?.order_cycle_id_in,
       'q[s]': $scope.sorting || 'completed_at desc',
-      shipping_method_id: $scope.shipping_method_id,
+      shipping_method_id: $scope.q?.shipping_method_id,
       per_page: $scope.per_page,
       page: page
     }
diff --git a/app/views/spree/admin/orders/_filters.html.haml b/app/views/spree/admin/orders/_filters.html.haml
index 656fb62e02..8432108996 100644
--- a/app/views/spree/admin/orders/_filters.html.haml
+++ b/app/views/spree/admin/orders/_filters.html.haml
@@ -35,8 +35,9 @@
       .field
         = label_tag nil, t(:shipping_method)
         = select_tag("shipping_method_id",
+          = select_tag("q[shipping_method_id]",
             options_for_select(Spree::ShippingMethod.managed_by(spree_current_user).collect {|s| [t("spree.shipping_method_names.#{s.name}"), s.id]}),
-            {include_blank: true, class: 'select2', 'ng-model' => 'shipping_method_id', 'ng-value' => 'shipping_method_id'})
+            {include_blank: true, class: 'select2', 'ng-model': 'q.shipping_method_id'})
     .field-block.alpha.eight.columns
       = label_tag nil, t(:distributors)
       = select_tag("q[distributor_id_in]",
diff --git a/spec/features/admin/orders_spec.rb b/spec/features/admin/orders_spec.rb
index 33a2693aec..0188df9eeb 100644
--- a/spec/features/admin/orders_spec.rb
+++ b/spec/features/admin/orders_spec.rb
@@ -134,7 +134,7 @@ feature '
       fill_in "Invoice number", with: "R123456"
       select2_select order_cycle.name, from: 'q_order_cycle_id_in'
       select2_select distributor.name, from: 'q_distributor_id_in'
-      select2_select shipping_method.name, from: 'shipping_method_id'
+      select2_select shipping_method.name, from: 'q_shipping_method_id'
       select2_select "complete", from: 'q_state_eq'
       fill_in "Email", with: user.email
       fill_in "First name begins with", with: "J"
@@ -151,7 +151,7 @@ feature '
       # Check every filters to be equal
       expect(find_field("Only show complete orders")).not_to be_checked
       expect(find_field("Invoice number").value).to eq "R123456"
-      expect(find("#s2id_shipping_method_id").text).to eq shipping_method.name
+      expect(find("#s2id_q_shipping_method_id").text).to eq shipping_method.name
       expect(find("#s2id_q_state_eq").text).to eq "complete"
       expect(find_field("Email").value).to eq user.email
       expect(find_field("First name begins with").value).to eq "J"

From 58a96c6500a6da7c9bd15dde2d03873983ba8fc6 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Fri, 21 May 2021 14:35:15 +0200
Subject: [PATCH 08/15] Add missing `]` char to be consistant

---
 app/views/spree/admin/orders/_filters.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/views/spree/admin/orders/_filters.html.haml b/app/views/spree/admin/orders/_filters.html.haml
index 8432108996..546645c043 100644
--- a/app/views/spree/admin/orders/_filters.html.haml
+++ b/app/views/spree/admin/orders/_filters.html.haml
@@ -19,7 +19,7 @@
         = text_field_tag "q[number_cont]", nil, "ng-model" => "q.number_cont", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
       .field
         = label_tag "q_email_cont", t(:email)
-        = email_field_tag "q[email_cont", nil, "ng-model" => "q.email_cont", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
+        = email_field_tag "q[email_cont]", nil, "ng-model" => "q.email_cont", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
     .four.columns
       .field
         = label_tag "q_bill_address_firstname_start", t(:first_name_begins_with)

From 303bf5420e128d47c2e87f0a76df3160690cc798 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Mon, 31 May 2021 09:43:59 +0200
Subject: [PATCH 09/15] Add select2WatchNgModel directive

 - Select2 components cannot handle ng-model correctly: they do not update if the ng-model change. Add a directive to watch the ng-model and update the component value
---
 .../directives/select2_watch_model.js.coffee  |  8 +++++++
 .../spree/admin/orders/_filters.html.haml     | 23 +++++++++++--------
 app/views/spree/admin/orders/index.html.haml  |  2 +-
 3 files changed, 22 insertions(+), 11 deletions(-)
 create mode 100644 app/assets/javascripts/admin/directives/select2_watch_model.js.coffee

diff --git a/app/assets/javascripts/admin/directives/select2_watch_model.js.coffee b/app/assets/javascripts/admin/directives/select2_watch_model.js.coffee
new file mode 100644
index 0000000000..510e0905f4
--- /dev/null
+++ b/app/assets/javascripts/admin/directives/select2_watch_model.js.coffee
@@ -0,0 +1,8 @@
+angular.module("ofn.admin").directive "select2WatchNgModel", () ->
+  restrict: 'E'
+  scope: true
+  require: "ngModel"
+  link: (scope, element, attrs, ngModel) ->
+    ngModel.$render = () ->
+      newValue = ngModel.$viewValue;
+      element.children(".select2").select2("val", newValue)
diff --git a/app/views/spree/admin/orders/_filters.html.haml b/app/views/spree/admin/orders/_filters.html.haml
index 546645c043..bc39f719e9 100644
--- a/app/views/spree/admin/orders/_filters.html.haml
+++ b/app/views/spree/admin/orders/_filters.html.haml
@@ -10,9 +10,10 @@
           = text_field_tag "q[completed_at_lteq]", nil, class: 'datepicker', datepicker: 'q.completed_at_lteq', 'ng-model' => 'q.completed_at_lteq', :placeholder => t(:stop)
       .field
         = label_tag nil, t(:status)
-        = select_tag("q[state_eq]",
-            options_for_select(Spree::Order.state_machines[:state].states.collect {|s| [t("spree.order_state.#{s.name}"), s.value]}),
-            {include_blank: true, class: 'select2', 'ng-model' => 'q.state_eq'})
+        %select2-watch-ng-model{'ng-model': 'q.state_eq'}
+          = select_tag("q[state_eq]",
+              options_for_select(Spree::Order.state_machines[:state].states.collect {|s| [t("spree.order_state.#{s.name}"), s.value]}),
+              {include_blank: true, class: 'select2', 'ng-model' => 'q.state_eq'})
     .four.columns
       .field
         = label_tag "q_number_cont", t(:order_number)
@@ -34,20 +35,22 @@
           = t(:show_only_complete_orders)
       .field
         = label_tag nil, t(:shipping_method)
-        = select_tag("shipping_method_id",
+        %select2-watch-ng-model{'ng-model': 'q.shipping_method_id'}
           = select_tag("q[shipping_method_id]",
             options_for_select(Spree::ShippingMethod.managed_by(spree_current_user).collect {|s| [t("spree.shipping_method_names.#{s.name}"), s.id]}),
             {include_blank: true, class: 'select2', 'ng-model': 'q.shipping_method_id'})
     .field-block.alpha.eight.columns
       = label_tag nil, t(:distributors)
-      = select_tag("q[distributor_id_in]",
-          options_for_select(Enterprise.is_distributor.managed_by(spree_current_user).map {|e| [e.name, e.id]}, params[:distributor_ids]),
-          {class: "select2 fullwidth", multiple: true, 'ng-model' => 'q.distributor_id_in'})
+      %select2-watch-ng-model{'ng-model': 'q.distributor_id_in'}
+        = select_tag("q[distributor_id_in]",
+            options_for_select(Enterprise.is_distributor.managed_by(spree_current_user).map {|e| [e.name, e.id]}, params[:distributor_ids]),
+            {class: "select2 fullwidth", multiple: true, 'ng-model' => 'q.distributor_id_in'})
     .field-block.omega.eight.columns
       = label_tag nil, t(:order_cycles)
-      = select_tag("q[order_cycle_id_in]",
-          options_for_select(OrderCycle.managed_by(spree_current_user).where('order_cycles.orders_close_at is not null').order('order_cycles.orders_close_at DESC').map {|oc| [oc.name, oc.id]}, params[:order_cycle_ids]),
-          {class: "select2 fullwidth", multiple: true, 'ng-model' => 'q.order_cycle_id_in'})
+      %select2-watch-ng-model{'ng-model': 'q.order_cycle_id_in'}
+        = select_tag("q[order_cycle_id_in]",
+            options_for_select(OrderCycle.managed_by(spree_current_user).where('order_cycles.orders_close_at is not null').order('order_cycles.orders_close_at DESC').map {|oc| [oc.name, oc.id]}, params[:order_cycle_ids]),
+            {class: "select2 fullwidth", multiple: true, 'ng-model' => 'q.order_cycle_id_in'})
     .clearfix
     .actions.filter-actions
       %div
diff --git a/app/views/spree/admin/orders/index.html.haml b/app/views/spree/admin/orders/index.html.haml
index 758fc4dd07..08899c50d0 100644
--- a/app/views/spree/admin/orders/index.html.haml
+++ b/app/views/spree/admin/orders/index.html.haml
@@ -8,7 +8,7 @@
 = render partial: 'spree/admin/shared/order_sub_menu'
 
 - content_for :main_ng_app_name do
-  = "admin.orders"
+  = "ofn.admin"
 
 - content_for :main_ng_ctrl_name do
   = "ordersCtrl"

From ea2cb4e6c09c9336fe8766d968894c57946c4f29 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Fri, 21 May 2021 17:41:38 +0200
Subject: [PATCH 10/15] Update flatpickr input value if ng-model change

---
 .../javascripts/admin/utils/directives/date_picker.js.coffee | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/app/assets/javascripts/admin/utils/directives/date_picker.js.coffee b/app/assets/javascripts/admin/utils/directives/date_picker.js.coffee
index 455215f99e..6645c8c620 100644
--- a/app/assets/javascripts/admin/utils/directives/date_picker.js.coffee
+++ b/app/assets/javascripts/admin/utils/directives/date_picker.js.coffee
@@ -2,10 +2,13 @@ angular.module("admin.utils").directive "datepicker", ($window, $timeout) ->
   require: "ngModel"
   link: (scope, element, attrs, ngModel) ->
     $timeout ->
-      flatpickr(element,  Object.assign(
+      flapickrInstance = flatpickr(element,  Object.assign(
                             {},
                             $window.FLATPICKR_DATE_DEFAULT, {
                             onOpen: (selectedDates, dateStr, instance) ->
                               instance.setDate(ngModel.$modelValue)
                             }
                           ));
+      ngModel.$render = () ->
+        newValue = ngModel.$viewValue;
+        flapickrInstance?.setDate(newValue)

From 385446807da0bd2b6a5e27a43be4388008223d15 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Fri, 21 May 2021 15:28:18 +0200
Subject: [PATCH 11/15] Add a clear filters button

 - This button clear all stored filters and then update results
---
 .../admin/orders/controllers/orders_controller.js.coffee  | 5 +++++
 .../admin/services/query_persistence.js.coffee            | 3 +++
 app/assets/stylesheets/admin/components/table-filter.scss | 8 +++++---
 app/views/spree/admin/orders/_filters.html.haml           | 8 +++++---
 config/locales/en.yml                                     | 1 +
 5 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
index ea0034c405..5e32a602d2 100644
--- a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
+++ b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
@@ -30,6 +30,11 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
       completed_at_not_null: true
     }
 
+  $scope.clearFilters = () ->
+    QueryPersistence.clearFilters()
+    $scope.setDefaults()
+    $scope.fetchResults()
+
   $scope.fetchResults = (page=1) ->
     startDateWithTime = $scope.appendStringIfNotEmpty($scope.q?.completed_at_gteq, ' 00:00:00')
     endDateWithTime = $scope.appendStringIfNotEmpty($scope.q?.completed_at_lteq, ' 23:59:59')
diff --git a/app/assets/javascripts/admin/services/query_persistence.js.coffee b/app/assets/javascripts/admin/services/query_persistence.js.coffee
index 0dad2341f6..0018151e42 100644
--- a/app/assets/javascripts/admin/services/query_persistence.js.coffee
+++ b/app/assets/javascripts/admin/services/query_persistence.js.coffee
@@ -25,3 +25,6 @@ angular.module("admin.indexUtils").factory 'QueryPersistence', (localStorageServ
         return true
 
       false
+
+    clearFilters: () ->
+      localStorageService.remove(@storageKey)
diff --git a/app/assets/stylesheets/admin/components/table-filter.scss b/app/assets/stylesheets/admin/components/table-filter.scss
index 51504e4589..5d7f2e7429 100644
--- a/app/assets/stylesheets/admin/components/table-filter.scss
+++ b/app/assets/stylesheets/admin/components/table-filter.scss
@@ -1,5 +1,4 @@
 #table-filter {
-
   .field {
     input[type="text"], input[type="phone"],
     input[type="email"], input[type="number"],
@@ -9,6 +8,9 @@
   }
 
   .actions {
-    text-align: center;
+    display: flex;
+    align-items: center;
+    justify-content: center;
+    column-gap: 20px;
   }
-}
\ No newline at end of file
+}
diff --git a/app/views/spree/admin/orders/_filters.html.haml b/app/views/spree/admin/orders/_filters.html.haml
index bc39f719e9..8a789b8c64 100644
--- a/app/views/spree/admin/orders/_filters.html.haml
+++ b/app/views/spree/admin/orders/_filters.html.haml
@@ -53,6 +53,8 @@
             {class: "select2 fullwidth", multiple: true, 'ng-model' => 'q.order_cycle_id_in'})
     .clearfix
     .actions.filter-actions
-      %div
-        %a.button.icon-search{'ng-click' => 'fetchResults()'}
-          = t(:filter_results)
+      %a.button.icon-search{'ng-click' => 'fetchResults()'}
+        = t(:filter_results)
+      %a.button{'ng-click' => 'clearFilters()', "id": "clear_filters_button"}
+        =  t(:clear_filters)
+          
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 8ac5f28653..b4798a7513 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -330,6 +330,7 @@ en:
   no_pending_payments: "No pending payments"
   invalid_payment_state: "Invalid payment state: %{state}"
   filter_results: Filter Results
+  clear_filters: Clear filters
   quantity: Quantity
   pick_up: Pick up
   ok: Ok

From 54c645e33a402eba477d334f05222f57e237e4c9 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Fri, 21 May 2021 15:22:35 +0200
Subject: [PATCH 12/15] Add tests for clearing all filters feature

 - and check each filter is well reinitialized
---
 spec/features/admin/orders_spec.rb | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/spec/features/admin/orders_spec.rb b/spec/features/admin/orders_spec.rb
index 0188df9eeb..b17c58fddc 100644
--- a/spec/features/admin/orders_spec.rb
+++ b/spec/features/admin/orders_spec.rb
@@ -113,10 +113,10 @@ feature '
   end
 
   context "save the filter params" do
-    scenario "when reloading the page" do
-      user = create(:user, email: 'an@email.com')
-      shipping_method = create(:shipping_method, name: "UPS Ground")
-      order = create(
+    let!(:shipping_method) { create(:shipping_method, name: "UPS Ground") }
+    let!(:user) { create(:user, email: 'an@email.com') }
+    let!(:order) do
+      create(
         :order,
         distributor: distributor,
         order_cycle: order_cycle,
@@ -126,7 +126,8 @@ feature '
         payment_state: 'balance_due',
         completed_at: 1.day.ago
       )
-
+    end
+    before :each do
       login_as_admin_and_visit spree.admin_orders_path
 
       # Specify each filters
@@ -145,7 +146,9 @@ feature '
       select_date_from_datepicker Time.zone.now
 
       page.find('a.icon-search').click
+    end
 
+    scenario "when reloading the page" do
       page.driver.refresh
 
       # Check every filters to be equal
@@ -157,7 +160,20 @@ feature '
       expect(find_field("First name begins with").value).to eq "J"
       expect(find_field("Last name begins with").value).to eq "D"
       expect(find("#q_completed_at_gteq").value).to eq 1.week.ago.strftime("%Y-%m-%d")
-      expect(find("#q_completed_at_lteq").value).to eq Time.now.strftime("%Y-%m-%d")
+      expect(find("#q_completed_at_lteq").value).to eq Time.zone.now.strftime("%Y-%m-%d")
+    end
+
+    scenario "and clear filters" do
+      find("a#clear_filters_button").click
+      expect(find_field("Only show complete orders")).to be_checked
+      expect(find_field("Invoice number").value).to eq ""
+      expect(find("#s2id_q_shipping_method_id").text).to be_empty
+      expect(find("#s2id_q_state_eq").text).to be_empty
+      expect(find_field("Email").value).to be_empty
+      expect(find_field("First name begins with").value).to be_empty
+      expect(find_field("Last name begins with").value).to be_empty
+      expect(find("#q_completed_at_gteq").value).to be_empty
+      expect(find("#q_completed_at_lteq").value).to be_empty
     end
   end
 end

From f167b093977269c9e2f414ca94eaba8dbf764962 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Fri, 21 May 2021 15:22:12 +0200
Subject: [PATCH 13/15] Add distributor and order cycle selectors in the test

---
 spec/features/admin/orders_spec.rb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/spec/features/admin/orders_spec.rb b/spec/features/admin/orders_spec.rb
index b17c58fddc..3ec1d12fff 100644
--- a/spec/features/admin/orders_spec.rb
+++ b/spec/features/admin/orders_spec.rb
@@ -156,6 +156,8 @@ feature '
       expect(find_field("Invoice number").value).to eq "R123456"
       expect(find("#s2id_q_shipping_method_id").text).to eq shipping_method.name
       expect(find("#s2id_q_state_eq").text).to eq "complete"
+      expect(find("#s2id_q_distributor_id_in").text).to eq distributor.name
+      expect(find("#s2id_q_order_cycle_id_in").text).to eq order_cycle.name
       expect(find_field("Email").value).to eq user.email
       expect(find_field("First name begins with").value).to eq "J"
       expect(find_field("Last name begins with").value).to eq "D"
@@ -169,6 +171,8 @@ feature '
       expect(find_field("Invoice number").value).to eq ""
       expect(find("#s2id_q_shipping_method_id").text).to be_empty
       expect(find("#s2id_q_state_eq").text).to be_empty
+      expect(find("#s2id_q_distributor_id_in").text).to be_empty
+      expect(find("#s2id_q_order_cycle_id_in").text).to be_empty
       expect(find_field("Email").value).to be_empty
       expect(find_field("First name begins with").value).to be_empty
       expect(find_field("Last name begins with").value).to be_empty

From 7008b5ec7b272d3a3bfea40180ed27a14f3a6f82 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Mon, 31 May 2021 10:43:54 +0200
Subject: [PATCH 14/15] Make a more generic solution: KeyValueMapStore

 - As QueryPersistence, stored in the localStorage too but it is now more generic and has nothing to do with Query
 - Add some js unit testing
---
 .../controllers/orders_controller.js.coffee   | 12 +++---
 .../services/key_value_map_store.js.coffee    | 29 ++++++++++++++
 .../services/query_persistence.js.coffee      | 30 ---------------
 .../key_value_map_store_spec.js.coffee        | 38 +++++++++++++++++++
 4 files changed, 73 insertions(+), 36 deletions(-)
 create mode 100644 app/assets/javascripts/admin/services/key_value_map_store.js.coffee
 delete mode 100644 app/assets/javascripts/admin/services/query_persistence.js.coffee
 create mode 100644 spec/javascripts/unit/admin/services/key_value_map_store_spec.js.coffee

diff --git a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
index 5e32a602d2..9620ce49d8 100644
--- a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
+++ b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
@@ -1,4 +1,4 @@
-angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, RequestMonitor, Orders, SortOptions, $window, $filter, $location, QueryPersistence) ->
+angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, RequestMonitor, Orders, SortOptions, $window, $filter, $location, KeyValueMapStore) ->
   $scope.RequestMonitor = RequestMonitor
   $scope.pagination = Orders.pagination
   $scope.orders = Orders.all
@@ -15,11 +15,11 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
   $scope.poll = 0
   $scope.rowStatus = {}
 
-  QueryPersistence.storageKey = 'ordersFilters'
-  QueryPersistence.storableFilters = ["q", "sorting", "page", "per_page"]
+  KeyValueMapStore.localStorageKey = 'ordersFilters'
+  KeyValueMapStore.storableKeys = ["q", "sorting", "page", "per_page"]
 
   $scope.initialise = ->
-    unless QueryPersistence.restoreFilters($scope)
+    unless KeyValueMapStore.restoreValues($scope)
       $scope.setDefaults()
 
     $scope.fetchResults()
@@ -31,7 +31,7 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
     }
 
   $scope.clearFilters = () ->
-    QueryPersistence.clearFilters()
+    KeyValueMapStore.clearKeyValueMap()
     $scope.setDefaults()
     $scope.fetchResults()
 
@@ -57,7 +57,7 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
       per_page: $scope.per_page,
       page: page
     }
-    QueryPersistence.setStoredFilters($scope)
+    KeyValueMapStore.setStoredValues($scope)
     RequestMonitor.load(Orders.index(params).$promise)
 
   $scope.appendStringIfNotEmpty = (baseString, stringToAppend) ->
diff --git a/app/assets/javascripts/admin/services/key_value_map_store.js.coffee b/app/assets/javascripts/admin/services/key_value_map_store.js.coffee
new file mode 100644
index 0000000000..1547aaab43
--- /dev/null
+++ b/app/assets/javascripts/admin/services/key_value_map_store.js.coffee
@@ -0,0 +1,29 @@
+angular.module("admin.indexUtils").factory 'KeyValueMapStore', (localStorageService)->
+  new class KeyValueMapStore
+    localStorageKey: ''
+    storableKeys: []
+
+    constructor: ->
+      localStorageService.setStorageType("sessionStorage")
+
+    getStoredKeyValueMap: ->
+      localStorageService.get(@localStorageKey) || {}
+
+    setStoredValues: (source) ->
+      keyValueMap = {}
+      for key in @storableKeys
+        keyValueMap[key] = source[key]
+      localStorageService.set(@localStorageKey, keyValueMap)
+
+    restoreValues: (target) ->
+      storedKeyValueMap = @getStoredKeyValueMap()
+      
+      return false if _.isEmpty(storedKeyValueMap)  
+      
+      for k,v of storedKeyValueMap
+       target[k] = v
+
+      return true
+
+    clearKeyValueMap: () ->
+      localStorageService.remove(@localStorageKey)
diff --git a/app/assets/javascripts/admin/services/query_persistence.js.coffee b/app/assets/javascripts/admin/services/query_persistence.js.coffee
deleted file mode 100644
index 0018151e42..0000000000
--- a/app/assets/javascripts/admin/services/query_persistence.js.coffee
+++ /dev/null
@@ -1,30 +0,0 @@
-angular.module("admin.indexUtils").factory 'QueryPersistence', (localStorageService)->
-  new class QueryPersistence
-    storageKey: ''
-    storableFilters: []
-
-    constructor: ->
-      localStorageService.setStorageType("sessionStorage")
-
-    getStoredFilters: ->
-      localStorageService.get(@storageKey) || {}
-
-    setStoredFilters: (scope) ->
-      filters = {}
-      for key in @storableFilters
-        filters[key] = scope[key]
-      localStorageService.set(@storageKey, filters)
-
-    restoreFilters: (scope) ->
-      storedFilters = @getStoredFilters()
-
-      unless _.isEmpty(storedFilters)
-        for k,v of storedFilters
-          scope[k] = v
-
-        return true
-
-      false
-
-    clearFilters: () ->
-      localStorageService.remove(@storageKey)
diff --git a/spec/javascripts/unit/admin/services/key_value_map_store_spec.js.coffee b/spec/javascripts/unit/admin/services/key_value_map_store_spec.js.coffee
new file mode 100644
index 0000000000..9d853f7f7a
--- /dev/null
+++ b/spec/javascripts/unit/admin/services/key_value_map_store_spec.js.coffee
@@ -0,0 +1,38 @@
+describe "Test KeyValueMapStore service", ->
+
+  KeyValueMapStore = null
+  
+  beforeEach ->
+    module "ofn.admin"
+
+  beforeEach inject (_KeyValueMapStore_) ->
+    KeyValueMapStore = _KeyValueMapStore_
+
+  it "set and restore filters", ->
+    KeyValueMapStore.localStorageKey = 'localStorageKey'
+    KeyValueMapStore.storableKeys = ["a", "b", "c"]
+    source =
+      a: "1",
+      b: "2",
+      d: "4"
+    KeyValueMapStore.setStoredValues(source)
+    source = {}
+    restored = KeyValueMapStore.restoreValues(source)
+    expect(restored).toEqual true
+    expect(source).toEqual {a: '1', b: '2'}
+
+  it "clear filters", ->
+    KeyValueMapStore.storageKey = 'localStorageKey'
+    KeyValueMapStore.storableFilters = ["a", "b", "c"]
+    source =
+      a: "1",
+      b: "2",
+      d: "4"
+    KeyValueMapStore.setStoredValues(source)
+    KeyValueMapStore.clearKeyValueMap()
+    source = {}
+    restored = KeyValueMapStore.restoreValues(source)
+    expect(restored).toEqual false
+    expect(source).toEqual {}
+
+

From 89ea9913e6187ecfaa1ebe07c574d5c6bc43c66b Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Bellet <jb.bellet@gmail.com>
Date: Thu, 17 Jun 2021 21:40:25 +0200
Subject: [PATCH 15/15] Checkbox is correctly handled with null value (and not
 false)

 - It's better to read the comment juste below the line... :angry: (https://github.com/openfoodfoundation/openfoodnetwork/pull/3076#issuecomment-440010498)
 - Add appropriate spec so it is now correctly tested!
---
 .../controllers/orders_controller.js.coffee   |  2 +-
 spec/features/admin/orders_spec.rb            | 24 +++++++++++++++++++
 2 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
index 9620ce49d8..3756a66266 100644
--- a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
+++ b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
@@ -49,7 +49,7 @@ angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, Reque
       'q[bill_address_firstname_start]': $scope.q?.bill_address_firstname_start,
       'q[bill_address_lastname_start]': $scope.q?.bill_address_lastname_start,
       # Set default checkbox values to null. See: https://github.com/openfoodfoundation/openfoodnetwork/pull/3076#issuecomment-440010498
-      'q[completed_at_not_null]': $scope.q?.completed_at_not_null,
+      'q[completed_at_not_null]': $scope.q?.completed_at_not_null || null,
       'q[distributor_id_in][]': $scope.q?.distributor_id_in,
       'q[order_cycle_id_in][]': $scope.q?.order_cycle_id_in,
       'q[s]': $scope.sorting || 'completed_at desc',
diff --git a/spec/features/admin/orders_spec.rb b/spec/features/admin/orders_spec.rb
index 3ec1d12fff..c777d6e548 100644
--- a/spec/features/admin/orders_spec.rb
+++ b/spec/features/admin/orders_spec.rb
@@ -112,6 +112,30 @@ feature '
     end
   end
 
+  context "test the 'Only show the complete orders' checkbox" do
+    scenario "display or not incomplete order" do
+      incomplete_order = create(:order, distributor: distributor, order_cycle: order_cycle)
+      complete_order = create(
+        :order,
+        distributor: distributor,
+        order_cycle: order_cycle,
+        user: user,
+        state: 'complete',
+        payment_state: 'balance_due',
+        completed_at: 1.day.ago
+      )
+      login_as_admin_and_visit spree.admin_orders_path
+      expect(page).to have_content complete_order.number
+      expect(page).to have_no_content incomplete_order.number
+
+      uncheck 'Only show complete orders'
+      page.find('a.icon-search').click
+
+      expect(page).to have_content complete_order.number
+      expect(page).to have_content incomplete_order.number
+    end
+  end
+
   context "save the filter params" do
     let!(:shipping_method) { create(:shipping_method, name: "UPS Ground") }
     let!(:user) { create(:user, email: 'an@email.com') }