From b2b6d3ab876a1d750a0ef6e2838fef3521e02557 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Thu, 28 Jan 2021 23:11:54 +0000
Subject: [PATCH] Relocate specs for #provided_by_order_cycle? method extracted
 from Order class to service

---
 spec/models/spree/order_spec.rb          | 28 ------------------------
 spec/services/order_fees_handler_spec.rb | 20 +++++++++++++++++
 2 files changed, 20 insertions(+), 28 deletions(-)

diff --git a/spec/models/spree/order_spec.rb b/spec/models/spree/order_spec.rb
index 0a495e6bf6..c886d5677d 100644
--- a/spec/models/spree/order_spec.rb
+++ b/spec/models/spree/order_spec.rb
@@ -588,34 +588,6 @@ describe Spree::Order do
     end
   end
 
-  describe "looking up whether a line item can be provided by an order cycle" do
-    it "returns true when the variant is provided" do
-      v = double(:variant)
-      line_item = double(:line_item, variant: v)
-      order_cycle = double(:order_cycle, variants: [v])
-      allow(subject).to receive(:order_cycle) { order_cycle }
-
-      expect(subject.send(:provided_by_order_cycle?, line_item)).to be true
-    end
-
-    it "returns false otherwise" do
-      v = double(:variant)
-      line_item = double(:line_item, variant: v)
-      order_cycle = double(:order_cycle, variants: [])
-      allow(subject).to receive(:order_cycle) { order_cycle }
-
-      expect(subject.send(:provided_by_order_cycle?, line_item)).to be false
-    end
-
-    it "returns false when there is no order cycle" do
-      v = double(:variant)
-      line_item = double(:line_item, variant: v)
-      allow(subject).to receive(:order_cycle) { nil }
-
-      expect(subject.send(:provided_by_order_cycle?, line_item)).to be false
-    end
-  end
-
   describe "getting the admin and handling charge" do
     let(:o) { create(:order) }
     let(:li) { create(:line_item, order: o) }
diff --git a/spec/services/order_fees_handler_spec.rb b/spec/services/order_fees_handler_spec.rb
index e77f0bcc29..f0358a49c9 100644
--- a/spec/services/order_fees_handler_spec.rb
+++ b/spec/services/order_fees_handler_spec.rb
@@ -38,4 +38,24 @@ describe OrderFeesHandler do
       service.create_order_fees!
     end
   end
+
+  context "checking if a line item can be provided by the order cycle" do
+    it "returns true when the variant is provided" do
+      allow(order_cycle).to receive(:variants) { [line_item.variant] }
+
+      expect(service.__send__(:provided_by_order_cycle?, line_item)).to be true
+    end
+
+    it "returns false otherwise" do
+      allow(order_cycle).to receive(:variants) { [] }
+
+      expect(service.__send__(:provided_by_order_cycle?, line_item)).to be false
+    end
+
+    it "returns false when there is no order cycle" do
+      allow(order).to receive(:order_cycle) { nil }
+
+      expect(service.__send__(:provided_by_order_cycle?, line_item)).to be false
+    end
+  end
 end