From b25d2ed32aaf4ca742150de0e53b1f0f1b9c0dcc Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 13 Jun 2024 10:51:35 +1000 Subject: [PATCH] Refactor to fix Metrics/AbcSize linter --- app/controllers/admin/column_preferences_controller.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/controllers/admin/column_preferences_controller.rb b/app/controllers/admin/column_preferences_controller.rb index e6b0103f57..5403a9a5ee 100644 --- a/app/controllers/admin/column_preferences_controller.rb +++ b/app/controllers/admin/column_preferences_controller.rb @@ -7,8 +7,8 @@ module Admin def bulk_update @cp_set.collection.each { |cp| authorize! :bulk_update, cp } - if @cp_set.save - respond_to do |format| + respond_to do |format| + if @cp_set.save format.json { render json: @cp_set.collection, each_serializer: Api::Admin::ColumnPreferenceSerializer } @@ -16,9 +16,7 @@ module Admin flash.now[:success] = t('.success') render :bulk_update, locals: { action: permitted_params[:action_name] } } - end - else - respond_to do |format| + else format.json { render json: { errors: @cp_set.errors }, status: :bad_request } format.turbo_stream { flash.now[:error] = @cp_set.errors.full_messages.to_sentence