diff --git a/lib/reporting/report_renderer.rb b/lib/reporting/report_renderer.rb index 0c56d6daab..274bdf95c2 100644 --- a/lib/reporting/report_renderer.rb +++ b/lib/reporting/report_renderer.rb @@ -15,7 +15,7 @@ module Reporting end def html_render? - @report.params[:report_format].in?(['', 'pdf']) + @report.params[:report_format].in?([nil, '', 'pdf']) end def display_header_row? diff --git a/lib/reporting/reports/packing/base.rb b/lib/reporting/reports/packing/base.rb index 585029dd38..e561f3a81b 100644 --- a/lib/reporting/reports/packing/base.rb +++ b/lib/reporting/reports/packing/base.rb @@ -29,13 +29,6 @@ module Reporting { quantity: :quantity } end - def custom_headers - return {} if html_render? - - # Use non translated headers to avoid breaking changes - @custom_headers ||= report_data.columns.index_by(&:itself).symbolize_keys - end - def default_params # Prevent breaking change in this report by hidding new columns by default { fields_to_hide: ["phone", "price"],