From b0a7497f2ae8778ae265aaf6facc7a5f17c1789a Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Tue, 7 Apr 2020 15:22:00 +0200 Subject: [PATCH] Remove another N+1 in product serialization --- app/serializers/api/admin/product_simple_serializer.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/serializers/api/admin/product_simple_serializer.rb b/app/serializers/api/admin/product_simple_serializer.rb index 181bb33f54..b5af292e81 100644 --- a/app/serializers/api/admin/product_simple_serializer.rb +++ b/app/serializers/api/admin/product_simple_serializer.rb @@ -1,9 +1,12 @@ class Api::Admin::ProductSimpleSerializer < ActiveModel::Serializer - attributes :id, :name + attributes :id, :name, :producer_id - has_one :supplier, key: :producer_id, embed: :id has_many :variants, key: :variants, serializer: Api::Admin::VariantSimpleSerializer + def producer_id + object.supplier_id + end + def on_hand return 0 if object.on_hand.nil?