From af33fc357e51940fc9219a1ab1b5e1ceb1f72026 Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Thu, 21 Nov 2024 15:25:53 +1100
Subject: [PATCH] Use shorter Alert syntax

I still think that some of these objects won't be visible in Bugsnag but
I don't want to test any more on cases that were broken before and may
not be relevant now.
---
 app/jobs/report_job.rb               | 6 +-----
 app/jobs/subscription_confirm_job.rb | 4 +---
 app/services/place_proxy_order.rb    | 4 +---
 3 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/app/jobs/report_job.rb b/app/jobs/report_job.rb
index e99eccae00..58c6142386 100644
--- a/app/jobs/report_job.rb
+++ b/app/jobs/report_job.rb
@@ -22,11 +22,7 @@ class ReportJob < ApplicationJob
 
     broadcast_result(channel, format, blob) if channel
   rescue StandardError => e
-    Alert.raise(e) do |payload|
-      payload.add_metadata :report, {
-        report_class:, user:, params:, format:
-      }
-    end
+    Alert.raise(e, { report: { report_class:, user:, params:, format: } })
 
     broadcast_error(channel)
   end
diff --git a/app/jobs/subscription_confirm_job.rb b/app/jobs/subscription_confirm_job.rb
index da5d388db9..a0a4f918d5 100644
--- a/app/jobs/subscription_confirm_job.rb
+++ b/app/jobs/subscription_confirm_job.rb
@@ -108,8 +108,6 @@ class SubscriptionConfirmJob < ApplicationJob
     record_and_log_error(:failed_payment, order, error_message)
     SubscriptionMailer.failed_payment_email(order).deliver_now
   rescue StandardError => e
-    Alert.raise(e) do |payload|
-      payload.add_metadata :subscription_data, { order:, error_message: }
-    end
+    Alert.raise(e, { subscription_data: { order:, error_message: } })
   end
 end
diff --git a/app/services/place_proxy_order.rb b/app/services/place_proxy_order.rb
index 189d4dc0ec..ed3c24dc14 100644
--- a/app/services/place_proxy_order.rb
+++ b/app/services/place_proxy_order.rb
@@ -54,9 +54,7 @@ class PlaceProxyOrder
 
     true
   rescue StandardError => e
-    Alert.raise(e) do |payload|
-      payload.add_metadata(:proxy_order, { subscription:, proxy_order: })
-    end
+    Alert.raise(e, { proxy_order: { subscription:, proxy_order: } })
     false
   end