From ae8a5b7f939134ad0281f1fc73ac5bbe5097a82d Mon Sep 17 00:00:00 2001 From: Neal Chambers Date: Fri, 28 Jul 2023 16:41:12 +0900 Subject: [PATCH] Safely autocorrect Lint/UnusedMethodArgument Inspecting 1480 files ........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: lib/reporting/queries/query_interface.rb:18:30: W: [Corrected] Lint/UnusedMethodArgument: Unused method argument - default. If it's necessary, use _ or _default as an argument name to indicate that it won't be used. If it's unnecessary, remove it. def sum_grouped(field, default = 0) ^^^^^^^ lib/reporting/queries/query_interface.rb:22:26: W: [Corrected] Lint/UnusedMethodArgument: Unused method argument - default. If it's necessary, use _ or _default as an argument name to indicate that it won't be used. If it's unnecessary, remove it. def sum_new(field, default = 0) ^^^^^^^ 1480 files inspected, 2 offenses detected, 2 offenses corrected --- .rubocop_todo.yml | 7 ------- lib/reporting/queries/query_interface.rb | 4 ++-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 80d87556df..cfa32511bc 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -141,13 +141,6 @@ Lint/RedundantSafeNavigation: Exclude: - 'app/models/spree/payment.rb' -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. -Lint/UnusedMethodArgument: - Exclude: - - 'lib/reporting/queries/query_interface.rb' - # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). Lint/UselessMethodDefinition: diff --git a/lib/reporting/queries/query_interface.rb b/lib/reporting/queries/query_interface.rb index b2b26b5f27..54d818cc9c 100644 --- a/lib/reporting/queries/query_interface.rb +++ b/lib/reporting/queries/query_interface.rb @@ -15,11 +15,11 @@ module Reporting NamedFunction.new("SUM", [coalesce(field, default)]) end - def sum_grouped(field, default = 0) + def sum_grouped(field, _default = 0) Case.new(sql_grouping(grouping_fields)).when(0).then(field.maximum).else(field.sum) end - def sum_new(field, default = 0) + def sum_new(field, _default = 0) Case.new(sql_grouping(grouping_fields)).when(0).then(field.maximum).else(sum_values(field)) end