From adf0340153e526a4ff80b51206fc7e2990728ca2 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Tue, 8 Oct 2024 16:47:43 +1100 Subject: [PATCH] Remove duplicate method The method `CheckoutCallbacks#valid_order_line_items?` was a duplicate of `OrderStockCheck#valid_order_line_items?`. Apparently, it had been extracted twice: * 1d074c2151289e880b4971e9e490f29fcdeda095 * 06eb98bdf4fe289ef1f1aaaddbfcbb5674dae09e But the first commit duplicated the method while the second moved the original declaration. --- app/controllers/concerns/checkout_callbacks.rb | 6 ------ 1 file changed, 6 deletions(-) diff --git a/app/controllers/concerns/checkout_callbacks.rb b/app/controllers/concerns/checkout_callbacks.rb index c7eb90ebde..f703fdc790 100644 --- a/app/controllers/concerns/checkout_callbacks.rb +++ b/app/controllers/concerns/checkout_callbacks.rb @@ -63,12 +63,6 @@ module CheckoutCallbacks end end - def valid_order_line_items? - @order.insufficient_stock_lines.empty? && - OrderCycles::DistributedVariantsService.new(@order.order_cycle, @order.distributor). - distributes_order_variants?(@order) - end - def ensure_order_not_completed redirect_to main_app.cart_path if @order.completed? end