From acdffb0aa15f069eb4897a42de3df94f431dac09 Mon Sep 17 00:00:00 2001 From: Ahmed Ejaz Date: Wed, 5 Mar 2025 04:14:51 +0500 Subject: [PATCH] revert "remove subquery for optimization" - we are using OR between two queries here: https://github.com/openfoodfoundation/openfoodnetwork/blob/53ec6621bc30aa86f64440c9b1f9f9357da9a1b1/app/services/search_orders.rb#L31-L32 - so to make it compatible with this, had to revert Throws following error: Relation passed to #or must be structurally compatible. Incompatible values: [:left_outer_joins] --- app/services/permissions/order.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/services/permissions/order.rb b/app/services/permissions/order.rb index aa6610ddd4..29d63b5a2f 100644 --- a/app/services/permissions/order.rb +++ b/app/services/permissions/order.rb @@ -24,7 +24,8 @@ module Permissions # Any orders that the user can edit def editable_orders orders = if @user.can_manage_line_items_in_orders_only? - produced_orders.joins(:distributor).where( + Spree::Order.joins(:distributor).where( + id: produced_orders.select(:id), distributor: { enable_producers_to_edit_orders: true } ) else