From ab30307b1a340492f0684b24bc3d7d78e0d41ae0 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Tue, 22 Oct 2019 21:58:43 +0100
Subject: [PATCH] Simplify #active_outgoing_variants

---
 lib/open_food_network/order_cycle_permissions.rb | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/lib/open_food_network/order_cycle_permissions.rb b/lib/open_food_network/order_cycle_permissions.rb
index f72fcec198..30bb031852 100644
--- a/lib/open_food_network/order_cycle_permissions.rb
+++ b/lib/open_food_network/order_cycle_permissions.rb
@@ -236,11 +236,7 @@ module OpenFoodNetwork
 
     def active_outgoing_variants(hub)
       @active_outgoing_variants ||= begin
-        active_variants = []
-        @order_cycle.exchanges.outgoing.where(receiver_id: hub).limit(1).each do |exchange|
-          active_variants = exchange.variants
-        end
-        active_variants
+        @order_cycle.exchanges.outgoing.where(receiver_id: hub).first.andand.variants || []
       end
     end