diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index fc721d94cc..0ec878e146 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,11 +1,40 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400 --no-auto-gen-timestamp` -# using RuboCop version 1.62.1. +# using RuboCop version 1.64.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, DefLikeMacros, AllowAdjacentOneLineDefs, NumberOfEmptyLines. +Layout/EmptyLineBetweenDefs: + Exclude: + - 'app/services/products_renderer.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Layout/EmptyLines: + Exclude: + - 'app/services/products_renderer.rb' + +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: aligned, indented, indented_relative_to_receiver +Layout/MultilineMethodCallIndentation: + Exclude: + - 'app/services/products_renderer.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: aligned, indented +Layout/MultilineOperationIndentation: + Exclude: + - 'app/services/products_renderer.rb' + # Offense count: 16 # Configuration parameters: AllowComments, AllowEmptyLambdas. Lint/EmptyBlock: @@ -22,11 +51,10 @@ Lint/EmptyBlock: - 'spec/jobs/subscription_placement_job_spec.rb' - 'spec/models/product_import/entry_validator_spec.rb' -# Offense count: 6 +# Offense count: 4 # Configuration parameters: AllowComments. Lint/EmptyClass: Exclude: - - 'spec/controllers/spree/admin/base_controller_spec.rb' - 'spec/lib/reports/report_loader_spec.rb' # Offense count: 1 @@ -80,7 +108,7 @@ Lint/UselessMethodDefinition: Exclude: - 'app/models/spree/gateway.rb' -# Offense count: 26 +# Offense count: 24 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max. Metrics/AbcSize: Exclude: @@ -102,7 +130,6 @@ Metrics/AbcSize: - 'lib/open_food_network/order_cycle_form_applicator.rb' - 'lib/open_food_network/order_cycle_permissions.rb' - 'lib/spree/core/controller_helpers/order.rb' - - 'lib/tasks/enterprises.rake' - 'spec/services/orders/checkout_restart_service_spec.rb' # Offense count: 9 @@ -123,7 +150,7 @@ Metrics/BlockNesting: Exclude: - 'app/models/spree/payment/processing.rb' -# Offense count: 46 +# Offense count: 47 # Configuration parameters: CountComments, Max, CountAsOne. Metrics/ClassLength: Exclude: @@ -175,7 +202,7 @@ Metrics/ClassLength: - 'lib/reporting/reports/enterprise_fee_summary/scope.rb' - 'lib/reporting/reports/xero_invoices/base.rb' -# Offense count: 34 +# Offense count: 32 # Configuration parameters: AllowedMethods, AllowedPatterns, Max. Metrics/CyclomaticComplexity: Exclude: @@ -185,7 +212,6 @@ Metrics/CyclomaticComplexity: - 'app/helpers/checkout_helper.rb' - 'app/helpers/order_cycles_helper.rb' - 'app/helpers/spree/admin/navigation_helper.rb' - - 'app/models/enterprise.rb' - 'app/models/enterprise_relationship.rb' - 'app/models/product_import/entry_validator.rb' - 'app/models/spree/ability.rb' @@ -206,7 +232,7 @@ Metrics/CyclomaticComplexity: - 'lib/spree/localized_number.rb' - 'spec/models/product_importer_spec.rb' -# Offense count: 25 +# Offense count: 24 # Configuration parameters: CountComments, Max, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Exclude: @@ -391,7 +417,6 @@ RSpecRails/HaveHttpStatus: - 'spec/controllers/user_registrations_controller_spec.rb' - 'spec/requests/admin/images_spec.rb' - 'spec/requests/api/routes_spec.rb' - - 'spec/requests/checkout/failed_checkout_spec.rb' - 'spec/requests/checkout/stripe_sca_spec.rb' - 'spec/requests/home_controller_spec.rb' - 'spec/requests/omniauth_callbacks_controller_spec.rb' @@ -407,7 +432,7 @@ RSpecRails/HttpStatus: - 'spec/controllers/spree/admin/products_controller_spec.rb' - 'spec/requests/api/orders_spec.rb' -# Offense count: 146 +# Offense count: 144 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Inferences. RSpecRails/InferredSpecType: @@ -511,7 +536,6 @@ RSpecRails/InferredSpecType: - 'spec/helpers/navigation_helper_spec.rb' - 'spec/helpers/order_cycles_helper_spec.rb' - 'spec/helpers/serializer_helper_spec.rb' - - 'spec/helpers/shared_helper_spec.rb' - 'spec/helpers/shop_helper_spec.rb' - 'spec/helpers/spree/admin/base_helper_spec.rb' - 'spec/helpers/spree/admin/general_settings_helper_spec.rb' @@ -545,7 +569,6 @@ RSpecRails/InferredSpecType: - 'spec/requests/api/routes_spec.rb' - 'spec/requests/api/v1/customers_spec.rb' - 'spec/requests/api_docs_spec.rb' - - 'spec/requests/checkout/failed_checkout_spec.rb' - 'spec/requests/checkout/paypal_spec.rb' - 'spec/requests/checkout/routes_spec.rb' - 'spec/requests/checkout/stripe_sca_spec.rb' @@ -758,7 +781,7 @@ Style/CaseEquality: Exclude: - 'spec/models/spree/payment_spec.rb' -# Offense count: 25 +# Offense count: 23 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: nested, compact @@ -785,7 +808,6 @@ Style/ClassAndModuleChildren: - 'app/serializers/api/taxon_serializer.rb' - 'app/serializers/api/variant_serializer.rb' - 'lib/open_food_network/locking.rb' - - 'spec/controllers/spree/admin/base_controller_spec.rb' - 'spec/models/spree/payment_method_spec.rb' # Offense count: 1 @@ -838,12 +860,6 @@ Style/HashEachMethods: - 'spec/models/product_importer_spec.rb' - 'spec/support/cancan_helper.rb' -# Offense count: 1 -# Configuration parameters: MinBranchesCount. -Style/HashLikeCase: - Exclude: - - 'app/models/enterprise.rb' - # Offense count: 4 # This cop supports unsafe autocorrection (--autocorrect-all). Style/MapToHash: @@ -939,12 +955,6 @@ Style/RedundantInterpolation: - 'lib/tasks/karma.rake' - 'spec/base_spec_helper.rb' -# Offense count: 8 -# This cop supports safe autocorrection (--autocorrect). -Style/RedundantLineContinuation: - Exclude: - - 'lib/reporting/reports/enterprise_fee_summary/scope.rb' - # Offense count: 19 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowedMethods, AllowedPatterns. @@ -987,34 +997,10 @@ Style/Send: - 'spec/services/variant_units/option_value_namer_spec.rb' - 'spec/support/localized_number_helper.rb' -# Offense count: 4 +# Offense count: 3 # This cop supports unsafe autocorrection (--autocorrect-all). Style/SlicingWithRange: Exclude: - 'app/helpers/spree/admin/navigation_helper.rb' - 'app/services/embedded_page_service.rb' - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' - -# Offense count: 25 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: Mode. -Style/StringConcatenation: - Exclude: - - 'app/controllers/admin/stripe_connect_settings_controller.rb' - - 'app/helpers/enterprises_helper.rb' - - 'app/helpers/spree/admin/base_helper.rb' - - 'app/mailers/spree/user_mailer.rb' - - 'app/models/enterprise.rb' - - 'app/models/spree/credit_card.rb' - - 'app/models/spree/payment_method.rb' - - 'app/serializers/api/cached_enterprise_serializer.rb' - - 'app/serializers/api/enterprise_shopfront_list_serializer.rb' - - 'app/services/embedded_page_service.rb' - - 'app/services/products_renderer.rb' - - 'lib/spree/api/controller_setup.rb' - - 'lib/spree/core/environment_extension.rb' - - 'spec/models/spree/line_item_spec.rb' - - 'spec/models/spree/product_spec.rb' - - 'spec/services/embedded_page_service_spec.rb' - - 'spec/support/features/datepicker_helper.rb' - - 'spec/system/admin/products_spec.rb'