From a8c0eef3d3adf2ea4d64727c1c746967e6285357 Mon Sep 17 00:00:00 2001 From: luisramos0 Date: Fri, 22 Mar 2019 23:23:10 +0000 Subject: [PATCH] Improve admin variants controller create action, it doesn't try to set on_hand and on_demand if there are previous errors in the variant --- .../spree/admin/variants_controller_decorator.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/controllers/spree/admin/variants_controller_decorator.rb b/app/controllers/spree/admin/variants_controller_decorator.rb index 039cb5a849..c422ae8b44 100644 --- a/app/controllers/spree/admin/variants_controller_decorator.rb +++ b/app/controllers/spree/admin/variants_controller_decorator.rb @@ -6,9 +6,13 @@ Spree::Admin::VariantsController.class_eval do def create on_demand = params[:variant].delete(:on_demand) on_hand = params[:variant].delete(:on_hand) + super - @object.on_demand = on_demand if @object.present? - @object.on_hand = on_hand.to_i if @object.present? + + if @object.present? && @object.valid? + @object.on_demand = on_demand if on_demand.present? + @object.on_hand = on_hand.to_i if on_hand.present? + end end def search