From a66a6197c7d3ebd0fe2dedcb6fdaf106e5036da4 Mon Sep 17 00:00:00 2001 From: cyrillefr Date: Tue, 15 Apr 2025 14:12:46 +0200 Subject: [PATCH] Disable cop Rails LexicallyScopedActionFilter --- .rubocop_styleguide.yml | 4 ++++ .rubocop_todo.yml | 24 ------------------------ 2 files changed, 4 insertions(+), 24 deletions(-) diff --git a/.rubocop_styleguide.yml b/.rubocop_styleguide.yml index ae1fb8345f..ead7f299be 100644 --- a/.rubocop_styleguide.yml +++ b/.rubocop_styleguide.yml @@ -115,6 +115,10 @@ Rails/ApplicationRecord: Rails/HasAndBelongsToMany: Enabled: false +# Cf. conversation https://github.com/openfoodfoundation/openfoodnetwork/pull/13251 +Rails/LexicallyScopedActionFilter: + Enabled: false + Rails/OutputSafety: Exclude: - spec/**/* diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ccded70330..947c30d85c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -474,30 +474,6 @@ RSpecRails/InferredSpecType: - 'spec/requests/voucher_adjustments_spec.rb' - 'spec/routing/stripe_spec.rb' -# Offense count: 35 -# Configuration parameters: Include. -# Include: app/controllers/**/*.rb, app/mailers/**/*.rb -Rails/LexicallyScopedActionFilter: - Exclude: - - 'app/controllers/admin/enterprise_groups_controller.rb' - - 'app/controllers/admin/enterprises_controller.rb' - - 'app/controllers/admin/order_cycles_controller.rb' - - 'app/controllers/admin/producer_properties_controller.rb' - - 'app/controllers/admin/product_import_controller.rb' - - 'app/controllers/admin/schedules_controller.rb' - - 'app/controllers/admin/subscriptions_controller.rb' - - 'app/controllers/concerns/checkout_callbacks.rb' - - 'app/controllers/registration_controller.rb' - - 'app/controllers/spree/admin/adjustments_controller.rb' - - 'app/controllers/spree/admin/payment_methods_controller.rb' - - 'app/controllers/spree/admin/payments_controller.rb' - - 'app/controllers/spree/admin/products_controller.rb' - - 'app/controllers/spree/admin/return_authorizations_controller.rb' - - 'app/controllers/spree/admin/search_controller.rb' - - 'app/controllers/spree/admin/shipping_methods_controller.rb' - - 'app/controllers/spree/admin/zones_controller.rb' - - 'app/controllers/spree/users_controller.rb' - # Offense count: 1 # Configuration parameters: TransactionMethods. Rails/TransactionExitStatement: