From a23b1b980da5cf2eedd1b3fcab270537f972b63a Mon Sep 17 00:00:00 2001 From: luisramos0 Date: Tue, 25 Sep 2018 12:34:38 +0100 Subject: [PATCH] =?UTF-8?q?Make=20Web=20engine=20an=20isolated=20namespace?= =?UTF-8?q?=20engine=20mounted=20on=20/=20(without=20/web=20prefix)=20This?= =?UTF-8?q?=20approach=20is=20better=20to=20separate=20concerns,=20see=20?= =?UTF-8?q?=E2=80=9CIsolated=20Engine=E2=80=9D=20here:=20https://api.rubyo?= =?UTF-8?q?nrails.org/v3.2/classes/Rails/Engine.html?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../cookies_banner/cookies_banner_controller.js.coffee | 2 +- engines/web/config/routes.rb | 8 +++----- engines/web/lib/web/engine.rb | 1 + 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/engines/web/app/assets/javascripts/web/cookies_banner/cookies_banner_controller.js.coffee b/engines/web/app/assets/javascripts/web/cookies_banner/cookies_banner_controller.js.coffee index d9444fbd78..a35951943a 100644 --- a/engines/web/app/assets/javascripts/web/cookies_banner/cookies_banner_controller.js.coffee +++ b/engines/web/app/assets/javascripts/web/cookies_banner/cookies_banner_controller.js.coffee @@ -1,6 +1,6 @@ Darkswarm.controller "CookiesBannerCtrl", ($scope, CookiesBannerService, $http, $window)-> $scope.acceptCookies = -> - $http.post('/web/api/cookies/consent') + $http.post('/api/cookies/consent') CookiesBannerService.close() CookiesBannerService.disable() diff --git a/engines/web/config/routes.rb b/engines/web/config/routes.rb index 26a1a21690..e9143b1c7d 100644 --- a/engines/web/config/routes.rb +++ b/engines/web/config/routes.rb @@ -1,9 +1,7 @@ Web::Engine.routes.draw do - namespace :web do - namespace :api do - scope '/cookies' do - resource :consent, only: [:show, :create, :destroy], controller: "cookies_consent" - end + namespace :api do + scope '/cookies' do + resource :consent, only: [:show, :create, :destroy], controller: "cookies_consent" end end end diff --git a/engines/web/lib/web/engine.rb b/engines/web/lib/web/engine.rb index 11a353a3fd..5285d6726b 100644 --- a/engines/web/lib/web/engine.rb +++ b/engines/web/lib/web/engine.rb @@ -1,4 +1,5 @@ module Web class Engine < ::Rails::Engine + isolate_namespace Web end end