From a1ad25f217c934a327eaa6fcd70eb2dd9a82b10f Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Tue, 4 Apr 2023 13:36:50 +1000 Subject: [PATCH] Fix failing specs --- spec/controllers/split_checkout_controller_spec.rb | 2 +- spec/system/consumer/split_checkout_spec.rb | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/spec/controllers/split_checkout_controller_spec.rb b/spec/controllers/split_checkout_controller_spec.rb index 60c36e5ade..9c834e7123 100644 --- a/spec/controllers/split_checkout_controller_spec.rb +++ b/spec/controllers/split_checkout_controller_spec.rb @@ -275,7 +275,7 @@ describe SplitCheckoutController, type: :controller do context "when adding fails" do it "returns 422 and an error message" do # Makes adding the voucher fails - allow(voucher).to receive(:compute_amount).and_return(0) + allow(voucher).to receive(:create_adjustment).and_return(nil) allow(Voucher).to receive(:find_by).and_return(voucher) put :update, params: params diff --git a/spec/system/consumer/split_checkout_spec.rb b/spec/system/consumer/split_checkout_spec.rb index 91a85fe289..8914600d14 100644 --- a/spec/system/consumer/split_checkout_spec.rb +++ b/spec/system/consumer/split_checkout_spec.rb @@ -1115,6 +1115,8 @@ describe "As a consumer, I want to checkout my order" do before do # Add voucher to the order voucher.create_adjustment(voucher.code, order) + # Update order so voucher adjustment is properly taken into account + order.update_order! visit checkout_step_path(:summary) end