From a1241415378ad1a85fa609fc98b5d96d7305d39d Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Tue, 11 May 2021 01:46:23 +0100 Subject: [PATCH] Move Shipment#line_items to private --- app/models/spree/shipment.rb | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/app/models/spree/shipment.rb b/app/models/spree/shipment.rb index 1a750dc207..447363cc7f 100644 --- a/app/models/spree/shipment.rb +++ b/app/models/spree/shipment.rb @@ -183,15 +183,6 @@ module Spree @scoper ||= OpenFoodNetwork::ScopeVariantToHub.new(order.distributor) end - def line_items - if order.complete? - inventory_unit_ids = inventory_units.pluck(:variant_id) - order.line_items.select { |li| inventory_unit_ids.include?(li.variant_id) } - else - order.line_items - end - end - def finalize! InventoryUnit.finalize_units!(inventory_units) manifest.each { |item| manifest_unstock(item) } @@ -292,6 +283,15 @@ module Spree private + def line_items + if order.complete? + inventory_unit_ids = inventory_units.pluck(:variant_id) + order.line_items.select { |li| inventory_unit_ids.include?(li.variant_id) } + else + order.line_items + end + end + def manifest_unstock(item) stock_location.unstock item.variant, item.quantity, self end