From 8e4d306901a3c2f33430e5468fb4c5c382366c6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Gald=C3=A1mez?= Date: Tue, 15 Oct 2024 08:33:42 -0300 Subject: [PATCH 1/2] Ignores name column on customer model It's not being used because now there are columns for first name and last name --- app/models/customer.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/models/customer.rb b/app/models/customer.rb index a60c0d8013..476dbc95f8 100644 --- a/app/models/customer.rb +++ b/app/models/customer.rb @@ -10,6 +10,8 @@ class Customer < ApplicationRecord include SetUnusedAddressFields + self.ignored_columns += ['name'] + acts_as_taggable searchable_attributes :first_name, :last_name, :email, :code From 2e29426834518eb0a05e686656afa4758a337a74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Gald=C3=A1mez?= Date: Wed, 16 Oct 2024 07:34:36 -0300 Subject: [PATCH 2/2] Deletes failing test It was a test associated with the migration from name to first_name + last_name --- spec/migrations/split_customer_names_spec.rb | 52 -------------------- 1 file changed, 52 deletions(-) delete mode 100644 spec/migrations/split_customer_names_spec.rb diff --git a/spec/migrations/split_customer_names_spec.rb b/spec/migrations/split_customer_names_spec.rb deleted file mode 100644 index 3d94e32edd..0000000000 --- a/spec/migrations/split_customer_names_spec.rb +++ /dev/null @@ -1,52 +0,0 @@ -# frozen_string_literal: true - -require 'spec_helper' -require_relative '../../db/migrate/20220105085730_migrate_customers_data' - -RSpec.describe MigrateCustomersData do - let!(:customer1) { - create(:customer, name: "Timmy Test", first_name: "", last_name: "", bill_address: nil) - } - let!(:customer2) { - create(:customer, - name: "Frank Lee Ridiculous", first_name: "", last_name: "", - bill_address: create(:address, first_name: "Frank Lee", last_name: "Ridiculous")) - } - let!(:customer3) { - create(:customer, name: "Shia Le Boeuf", first_name: "", last_name: "", - bill_address: create(:address, first_name: "Shia", last_name: "Le Boeuf")) - } - let!(:customer4) { - create(:customer, name: "No Eyed Deer", first_name: "", last_name: "", bill_address: nil) - } - let!(:customer5) { - create(:customer, name: " Space Invader ", first_name: "", last_name: "", - bill_address: nil) - } - let!(:customer6) { - create(:customer, name: "How Many Names Do You Need?", first_name: "", last_name: "", - bill_address: nil) - } - let!(:customer7) { - create(:customer, - name: "Customer Name", first_name: "", last_name: "", - bill_address: create(:address, first_name: "Different", last_name: "AddressName")) - } - - it "migrates customer names" do - subject.up - - [ - customer1, customer2, customer3, customer4, - customer5, customer6, customer7, - ].map(&:reload) - - expect([customer1.first_name, customer1.last_name]).to eq ["Timmy", "Test"] - expect([customer2.first_name, customer2.last_name]).to eq ["Frank Lee", "Ridiculous"] - expect([customer3.first_name, customer3.last_name]).to eq ["Shia", "Le Boeuf"] - expect([customer4.first_name, customer4.last_name]).to eq ["No", "Eyed Deer"] - expect([customer5.first_name, customer5.last_name]).to eq ["Space", "Invader"] - expect([customer6.first_name, customer6.last_name]).to eq ["How", "Many Names Do You Need?"] - expect([customer7.first_name, customer7.last_name]).to eq ["Customer", "Name"] - end -end