From a082a95ea197169c1cce17860b04a454bded8293 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Wed, 12 Mar 2025 13:03:35 +1100 Subject: [PATCH] Split method into simpler pieces --- app/jobs/backorder_job.rb | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/app/jobs/backorder_job.rb b/app/jobs/backorder_job.rb index 1db8d1d6ad..64c9cd8e62 100644 --- a/app/jobs/backorder_job.rb +++ b/app/jobs/backorder_job.rb @@ -59,13 +59,7 @@ class BackorderJob < ApplicationJob place_order(user, order, orderer, backorder) - items.each do |item| - variant = item.variant - quantity = ordered_quantities[item] - next if quantity.zero? - - variant.on_hand += quantity if variant.on_demand - end + adjust_stock(items, ordered_quantities) end # We look at linked variants which are either stock controlled or @@ -143,4 +137,14 @@ class BackorderJob < ApplicationJob order.exchange.semantic_links.create!(semantic_id: placed_order.semanticId) end + + def adjust_stock(items, ordered_quantities) + items.each do |item| + variant = item.variant + quantity = ordered_quantities[item] + next if quantity.zero? + + variant.on_hand += quantity if variant.on_demand + end + end end