From 9efee1b0be1bc67cd99471777206dcc3e1c2ffb9 Mon Sep 17 00:00:00 2001 From: Cillian O'Ruanaidh Date: Fri, 28 Aug 2020 12:20:47 +0100 Subject: [PATCH] In bulk coop report service spec just check array has the same elements but don't check the order. The #table_items methos seems to return line items in different order sometimes making this test a bit flaky. The test passed on Semaphore previously and is passing in development. I don't think the order matters so using :match_array instead of :eq. --- .../reports/bulk_coop/bulk_coop_report_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/engines/order_management/spec/services/order_management/reports/bulk_coop/bulk_coop_report_spec.rb b/engines/order_management/spec/services/order_management/reports/bulk_coop/bulk_coop_report_spec.rb index 3c609cf952..5a580481de 100644 --- a/engines/order_management/spec/services/order_management/reports/bulk_coop/bulk_coop_report_spec.rb +++ b/engines/order_management/spec/services/order_management/reports/bulk_coop/bulk_coop_report_spec.rb @@ -36,7 +36,7 @@ describe OrderManagement::Reports::BulkCoop::BulkCoopReport do o2.line_items << li2 report = OrderManagement::Reports::BulkCoop::BulkCoopReport.new user, {}, true - expect(report.table_items).to eq([li1, li2]) + expect(report.table_items).to match_array [li1, li2] report = OrderManagement::Reports::BulkCoop::BulkCoopReport.new( user, { q: { completed_at_gt: 2.days.ago } }, true @@ -60,7 +60,7 @@ describe OrderManagement::Reports::BulkCoop::BulkCoopReport do o2.line_items << li2 report = OrderManagement::Reports::BulkCoop::BulkCoopReport.new user, {}, true - expect(report.table_items).to eq([li1, li2]) + expect(report.table_items).to match_array [li1, li2] report = OrderManagement::Reports::BulkCoop::BulkCoopReport.new( user, { q: { distributor_id_in: [d1.id] } }, true