From 9e5c21f7cdae649c8284e1f6052d877f5bb1c9da Mon Sep 17 00:00:00 2001 From: filipefurtad0 Date: Wed, 12 Jun 2024 18:53:29 -0600 Subject: [PATCH] Corrects test case by adding expect has_select? only returns true or false, it requires an assertion to assure the test is evaluated Improves syntax --- spec/system/admin/products_v3/products_spec.rb | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/spec/system/admin/products_v3/products_spec.rb b/spec/system/admin/products_v3/products_spec.rb index f9606491e1..c60e11d698 100644 --- a/spec/system/admin/products_v3/products_spec.rb +++ b/spec/system/admin/products_v3/products_spec.rb @@ -1419,9 +1419,8 @@ RSpec.describe 'As an enterprise user, I can manage my products', feature: :admi it "shows only suppliers that I manage or have permission to" do visit spree.admin_products_path - within row_containing_name(product_supplied.name) do - page.has_select?( + expect(page).to have_select( '_products_0_supplier_id', options: [ supplier_managed1.name, supplier_managed2.name, supplier_permitted.name @@ -1430,11 +1429,11 @@ RSpec.describe 'As an enterprise user, I can manage my products', feature: :admi end within row_containing_name(product_supplied_permitted.name) do - page.has_select?( - '_products_0_supplier_id', + expect(page).to have_select( + '_products_1_supplier_id', options: [ supplier_managed1.name, supplier_managed2.name, supplier_permitted.name - ], selected: supplier_managed1.name + ], selected: supplier_permitted.name ) end end