From 9e09a3b37911fec38aa4e623612043f1e5768ac8 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Fri, 9 Aug 2019 10:41:09 +0100 Subject: [PATCH] Memoize #active_outgoing_variants result --- lib/open_food_network/order_cycle_permissions.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/open_food_network/order_cycle_permissions.rb b/lib/open_food_network/order_cycle_permissions.rb index 261038a247..cf149eca8a 100644 --- a/lib/open_food_network/order_cycle_permissions.rb +++ b/lib/open_food_network/order_cycle_permissions.rb @@ -235,11 +235,13 @@ module OpenFoodNetwork end def active_outgoing_variants(hub) - active_variants = [] - @order_cycle.exchanges.outgoing.where(receiver_id: hub).limit(1).each do |exchange| - active_variants = exchange.variants + @active_outgoing_variants ||= begin + active_variants = [] + @order_cycle.exchanges.outgoing.where(receiver_id: hub).limit(1).each do |exchange| + active_variants = exchange.variants + end + active_variants end - active_variants end def user_manages_coordinator_or(enterprise)