From 9d5ca2255b86423aaac7eb7d45eda593e3522939 Mon Sep 17 00:00:00 2001 From: David Cook Date: Tue, 7 Mar 2023 09:22:45 +1100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Maikel --- spec/jobs/webhook_delivery_job_spec.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/jobs/webhook_delivery_job_spec.rb b/spec/jobs/webhook_delivery_job_spec.rb index 8f90c3c4e5..7add4ca4e1 100644 --- a/spec/jobs/webhook_delivery_job_spec.rb +++ b/spec/jobs/webhook_delivery_job_spec.rb @@ -22,7 +22,7 @@ describe WebhookDeliveryJob do end it "delivers a payload" do - Timecop.freeze(Time.zone.now) do + Timecop.freeze do expected_body = { id: /.+/, at: Time.zone.now.to_s, @@ -48,9 +48,9 @@ describe WebhookDeliveryJob do ] private_addresses.each do |url| - # Unfortunately this isn't allowed in CI, but it should work in your - # development environment. - xit "rejects private address #{url}" do + it "rejects private address #{url}" do + # Github Actions doesn't allow local connections. + pending if ENV["CI"] expect { WebhookDeliveryJob.perform_now(url, event, data) }.to raise_error(PrivateAddressCheck::PrivateConnectionAttemptedError)