record subscription issue if no order is generated

This commit is contained in:
Andy Brett
2021-03-24 12:16:25 -07:00
parent 4bddc59696
commit 9d2fd373ce
4 changed files with 28 additions and 6 deletions

View File

@@ -13,8 +13,8 @@ class SubscriptionPlacementJob < ActiveJob::Base
private
delegate :record_order, :record_success, :record_issue, to: :summarizer
delegate :record_and_log_error, :send_placement_summary_emails, to: :summarizer
delegate :record_success, :record_issue, :record_subscription_issue, to: :summarizer
delegate :record_order, :record_and_log_error, :send_placement_summary_emails, to: :summarizer
def summarizer
@summarizer ||= OrderManagement::Subscriptions::Summarizer.new
@@ -30,6 +30,8 @@ class SubscriptionPlacementJob < ActiveJob::Base
def place_order_for(proxy_order)
JobLogger.logger.info("Placing Order for Proxy Order #{proxy_order.id}")
initialise_order(proxy_order)
return record_subscription_issue(proxy_order.subscription) if proxy_order.order.nil?
place_order(proxy_order.order)
end

View File

@@ -19,3 +19,11 @@
- orders.each_with_index do |order, i|
%a{ href: order_url(order) }>= order.number
= ", " if i < orders.count - 1
- if summary.subscription_issues.any?
- subscription_issues = summary.subscription_issues
%h4= t(".other.title", count: subscription_issues.count)
%p= t(".other.explainer")
- subscription_issues.each_with_index do |subscription_id, i|
%a{ href: edit_admin_subscription_url(subscription_id) }>= subscription_id
= ", " if i < subscription_issues.count - 1