From 9d1d8513e7cd9e24c984bd5231acb8e220ee14d3 Mon Sep 17 00:00:00 2001 From: Pau Perez Date: Mon, 21 Jan 2019 12:32:48 +0100 Subject: [PATCH] Make controller req. params a bit more obvious --- spec/controllers/spree/orders_controller_spec.rb | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/spec/controllers/spree/orders_controller_spec.rb b/spec/controllers/spree/orders_controller_spec.rb index 78e1dc6e5a..9b71d9e636 100644 --- a/spec/controllers/spree/orders_controller_spec.rb +++ b/spec/controllers/spree/orders_controller_spec.rb @@ -176,10 +176,6 @@ describe Spree::OrdersController, type: :controller do let(:payment_fee) { 5 } let(:item_num) { order.line_items.length } let(:expected_fees) { item_num * (shipping_fee + payment_fee) } - let(:params) { { order: { line_items_attributes: { - "0" => {id: line_item1.id, quantity: 1}, - "1" => {id: line_item2.id, quantity: 0} - } } } } before do allow(Spree::Config).to receive(:shipment_inc_vat) { true } @@ -196,10 +192,13 @@ describe Spree::OrdersController, type: :controller do end it "updates the fees" do - # Setting quantity of an item to zero - spree_post :update, params + spree_post :update, { + order: { line_items_attributes: { + "0" => { id: line_item1.id, quantity: 1 }, + "1" => { id: line_item2.id, quantity: 0 } + } } + } - # Check if fees got updated order.reload expect(order.line_items.count).to eq 1 expect(order.adjustment_total).to eq expected_fees - shipping_fee - payment_fee