From 9c3bdc6b9b37d7ca6c1e4df535df88bb216d2ff8 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Tue, 14 Mar 2023 14:24:04 +1100 Subject: [PATCH] Remove unnecessary table join And use Rails syntax for clarity and future extensions. --- engines/dfc_provider/app/services/variant_fetcher.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/engines/dfc_provider/app/services/variant_fetcher.rb b/engines/dfc_provider/app/services/variant_fetcher.rb index e99eb8dd02..df3fd86f82 100644 --- a/engines/dfc_provider/app/services/variant_fetcher.rb +++ b/engines/dfc_provider/app/services/variant_fetcher.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -# Service used to fetch variants related to an entreprise. +# Service used to fetch variants related to an enterprise. # It improves maintenance as it is the central point requesting # Spree::Variant inside the DfcProvider engine. class VariantFetcher @@ -10,7 +10,7 @@ class VariantFetcher def scope Spree::Variant.not_master. - joins(product: :supplier). - where('enterprises.id' => @enterprise.id) + joins(:product). + where(spree_products: { supplier: @enterprise }) end end