From 9c2010a43ebe482ff0749caead7415fe06f20d45 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 26 Mar 2021 19:22:36 +0000
Subject: [PATCH] Update SubscriptionLineItem#variant

---
 app/models/subscription_line_item.rb | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/app/models/subscription_line_item.rb b/app/models/subscription_line_item.rb
index 86f3a00577..9c04dc9a76 100644
--- a/app/models/subscription_line_item.rb
+++ b/app/models/subscription_line_item.rb
@@ -1,6 +1,6 @@
 class SubscriptionLineItem < ActiveRecord::Base
   belongs_to :subscription, inverse_of: :subscription_line_items
-  belongs_to :variant, class_name: 'Spree::Variant'
+  belongs_to :variant, -> { with_deleted }, class_name: 'Spree::Variant'
 
   validates :subscription, presence: true
   validates :variant, presence: true
@@ -12,11 +12,6 @@ class SubscriptionLineItem < ActiveRecord::Base
     (price_estimate || 0) * (quantity || 0)
   end
 
-  # Ensure SubscriptionLineItem always has access to soft-deleted Variant attribute
-  def variant
-    Spree::Variant.unscoped { super }
-  end
-
   # Used to calculators to estimate fees
   alias_method :amount, :total_estimate