From 9bb617d7482eea82ada8fa8509d7d1aa3502828f Mon Sep 17 00:00:00 2001
From: cyrillefr <cyrille.vasseur@gmail.com>
Date: Thu, 6 Mar 2025 23:42:53 +0100
Subject: [PATCH] Fixes some rubocop linting offenses - part III

---
 .rubocop_todo.yml                           | 17 -----------------
 app/models/spree/gateway/pay_pal_express.rb |  2 +-
 app/services/products_renderer.rb           |  1 -
 spec/lib/reports/report_loader_spec.rb      |  8 ++++----
 4 files changed, 5 insertions(+), 23 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 28e32673a1..c3a7a14fe9 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -6,12 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLines:
-  Exclude:
-    - 'app/services/products_renderer.rb'
-
 # Offense count: 16
 # Configuration parameters: AllowComments, AllowEmptyLambdas.
 Lint/EmptyBlock:
@@ -28,17 +22,6 @@ Lint/EmptyBlock:
     - 'spec/jobs/subscription_placement_job_spec.rb'
     - 'spec/models/product_import/entry_validator_spec.rb'
 
-# Offense count: 4
-# Configuration parameters: AllowComments.
-Lint/EmptyClass:
-  Exclude:
-    - 'spec/lib/reports/report_loader_spec.rb'
-
-# Offense count: 1
-Lint/FloatComparison:
-  Exclude:
-    - 'app/models/spree/gateway/pay_pal_express.rb'
-
 # Offense count: 24
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
diff --git a/app/models/spree/gateway/pay_pal_express.rb b/app/models/spree/gateway/pay_pal_express.rb
index d4c669097f..e24062a4ce 100644
--- a/app/models/spree/gateway/pay_pal_express.rb
+++ b/app/models/spree/gateway/pay_pal_express.rb
@@ -84,7 +84,7 @@ module Spree
       end
 
       def refund(payment, amount)
-        refund_type = payment.amount == amount.to_f ? "Full" : "Partial"
+        refund_type = payment.amount == amount.to_d ? "Full" : "Partial"
         refund_transaction = provider.build_refund_transaction(
           TransactionID: payment.source.transaction_id,
           RefundType: refund_type,
diff --git a/app/services/products_renderer.rb b/app/services/products_renderer.rb
index 90b9e8e029..12ccbb19f8 100644
--- a/app/services/products_renderer.rb
+++ b/app/services/products_renderer.rb
@@ -2,7 +2,6 @@
 
 require 'open_food_network/scope_product_to_hub'
 
-
 class ProductsRenderer
   include Pagy::Backend
 
diff --git a/spec/lib/reports/report_loader_spec.rb b/spec/lib/reports/report_loader_spec.rb
index af2b877833..a7a1247ddd 100644
--- a/spec/lib/reports/report_loader_spec.rb
+++ b/spec/lib/reports/report_loader_spec.rb
@@ -5,13 +5,13 @@ require 'spec_helper'
 module Reporting
   module Reports
     module Bananas
-      class Base; end
-      class Green; end
-      class Yellow; end
+      const_set "Base", Class.new
+      const_set "Green", Class.new
+      const_set "Yellow", Class.new
     end
 
     module Orange
-      class OrangeReport; end
+      const_set "OrangeReport", Class.new
     end
   end
 end