From f3f7fba855aa173905253432403acfdf27323e75 Mon Sep 17 00:00:00 2001 From: SuprajaR Date: Mon, 3 Jan 2022 22:28:56 +0530 Subject: [PATCH 1/2] Replacing text with translation --- app/assets/javascripts/admin/bulk_product_update.js.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/admin/bulk_product_update.js.coffee b/app/assets/javascripts/admin/bulk_product_update.js.coffee index cd5a951aca..9ee52b7454 100644 --- a/app/assets/javascripts/admin/bulk_product_update.js.coffee +++ b/app/assets/javascripts/admin/bulk_product_update.js.coffee @@ -144,7 +144,7 @@ angular.module("ofn.admin").controller "AdminProductEditCtrl", ($scope, $timeout $scope.variantIdCounter $scope.deleteProduct = (product) -> - if confirm("Are you sure?") + if confirm(t('are_you_sure')) $http( method: "DELETE" url: "/api/v0/products/" + product.id From f9a1b177095ca7de484a6858c5f10a16895eb8bf Mon Sep 17 00:00:00 2001 From: SuprajaR Date: Tue, 4 Jan 2022 00:10:38 +0530 Subject: [PATCH 2/2] asserted the confirmation msg in test --- spec/javascripts/unit/admin/bulk_product_update_spec.js.coffee | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/javascripts/unit/admin/bulk_product_update_spec.js.coffee b/spec/javascripts/unit/admin/bulk_product_update_spec.js.coffee index 9369342591..a53c0732b9 100644 --- a/spec/javascripts/unit/admin/bulk_product_update_spec.js.coffee +++ b/spec/javascripts/unit/admin/bulk_product_update_spec.js.coffee @@ -822,6 +822,7 @@ describe "AdminProductEditCtrl", -> $scope.dirtyProducts = {} $httpBackend.expectDELETE("/api/v0/products/13").respond 200, "data" $scope.deleteProduct $scope.products[1] + expect(window.confirm).toHaveBeenCalledWith "Are you sure?" $httpBackend.flush() it "removes the specified product from both $scope.products and $scope.dirtyProducts (if it exists there)", ->