From 9a5452cd52bcc9ecca2d1fef37f0222d0f9b3cbe Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Thu, 12 Mar 2020 12:21:46 +0100 Subject: [PATCH] Delete test in line_items_controller_spec.rb Rails 4 does not recognise requests to destroy routes without ids as valid routes. Fixes: 14) LineItemsController destroying a line item on a completed order without a line item id fails and raises an error Failure/Error: delete :destroy ActionController::UrlGenerationError: No route matches {:action=>"destroy", :controller=>"line_items"} # ./spec/controllers/line_items_controller_spec.rb:46:in `block (5 levels) in ' --- spec/controllers/line_items_controller_spec.rb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/spec/controllers/line_items_controller_spec.rb b/spec/controllers/line_items_controller_spec.rb index 2a4dbd8835..7e4e76bac9 100644 --- a/spec/controllers/line_items_controller_spec.rb +++ b/spec/controllers/line_items_controller_spec.rb @@ -41,13 +41,6 @@ describe LineItemsController, type: :controller do before { allow(controller).to receive_messages spree_current_user: item.order.user } - context "without a line item id" do - it "fails and raises an error" do - delete :destroy - expect(response.status).to eq 404 - end - end - context "with a line item id" do let(:params) { { format: :json, id: item } }